850988 - [socorro-crashstats] The drop down for products are in a different order and is missing Camino

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: django dropdown screenshot

1. go to https://crash-stats-django.mozilla.org/
2. select the drop down for Products and look at the list

Expected : the same list as https://crash-stats.mozilla.com
Actual : the list is in different order and is missing Camino

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: crash-stats non-django

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: from automation

Comment 3

[Robert Helmer [:rhelmer]]

Missing Camino is expected, we no longer show products that have no active releases.

The sort order is odd; seems to be in natural order on the old site (order the products were added), not sure what is going on in the new site.

Comment 4

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> Missing Camino is expected, we no longer show products that have no active
> releases.

Hmm, OK, not sure if I find that good or bad, but it's reasonable.

> The sort order is odd; seems to be in natural order on the old site (order
> the products were added), not sure what is going on in the new site.

Exactly that it's no easily explainable order is what makes me wonder. Natural order is fine for now, if the order would be open for admins to define, that would be a nice touch (so we could order by "project importance"). Right now it looks rather random, and I'd rather not have us ship this as primary UI when we don't understand that rather prominent order.

Comment 5

[Matt Brandt [:mbrandt]]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> The sort order is odd; seems to be in natural order on the old site (order
> the products were added), not sure what is going on in the new site.

The bit that would help QA is to know what order to expect - we have at least one test that looks at sort order.

Comment 6

[Laura Thomson :laura]

Still blocking because it breaks automation.

Comment 7

[Brandon Savage [:brandon]]

Looking at the way the data is constructed, it comes into the app in the format it is displayed in. I'm going to investigate the format for how it comes into the PHP app and see if there's a difference. But there is no orderby key or obvious way of ordering the data.

Comment 8

[Robert Helmer [:rhelmer]]

OK looks like the problem is the middleware API, the older one does:

https://github.com/mozilla/socorro/blob/master/socorro/services/currentVersions.py#L30

The new API does this instead:

https://github.com/mozilla/socorro/blob/master/socorro/external/postgresql/products.py#L26

Adrian, which is correct?

Comment 9

[[DEACTIVATED] Adrian Gaudebert]

As it causes bugs, the first service is right in ordering in descending order. But the second second should be used, the first one being depreciated. I thus filed bug 863458 to solve this in the middleware.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/fdc1c54cd7bd4bbd9b4ce7a31c743d8f1e20022c
Fixes bug 850988 - Corrected the order of products in dropdowns.

https://github.com/mozilla/socorro-crashstats/commit/2b17e506e49b2b85df9d5b1b03870f0cd4c2bd02
Merge pull request #324 from AdrianGaudebert/850988-products-order

Fixes bug 850988 - Corrected the order of products in dropdowns.

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening for clarification:

Hi Adrian, I'm reopening the bug for some clarification. In comment 9 you note that the sort order should be in descending order.

Here's what I'm seeing - the sort order doesn't appear to have been corrected.

crash-stats-django.allizom.org:
- Firefox
- Thunderbird
- Fennec
- FennecAndroid
- SeaMonkey
- WebappRuntimeMobile
- MetroFirefox

crash-stats.allizom.org:
- Firefox
- Thunderbird
- Camino
- SeaMonkey
- Fennec
- FennecAndroid
- WebappRuntime
- B2G
- WebappRuntimeMobile
- MetroFirefox

Comment 12

[[DEACTIVATED] Adrian Gaudebert]

@Matt the order on the django site is the right one: it misses Camino that has no release, and it reflects what the database has as a sorting value. If your tests are expecting the older order, they should now expect what you see on socorro-crashstats. 

KaiRo can confirm. And if that order is not correct, then we should file a bug to have it fixed in the database.

Comment 13

[Matt Brandt [:mbrandt]]

Adrian, thanks for the clarification in irc. In comment 9 you mentioned descending order for the products and that's where I was confused .. you meant descending order for product versions.

As noted in irc the product order is set by the admin user in the database.

QA verified fixed.

Comment 14

[Robert Kaiser]

The list in comment #11 suggests that crash-stats-django.allizom.org is missing more than just Camino but that's actually not the case. I think we might want to reorder a bit more at some point, but the order I'm seeing on this site right now looks OK to me.

Comment 15

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #14)
> The list in comment #11 suggests that crash-stats-django.allizom.org is
> missing more than just Camino but that's actually not the case. I think we
> might want to reorder a bit more at some point, but the order I'm seeing on
> this site right now looks OK to me.

per comment 3, missing camino is expected since we only show products if they have active releases. This is a slight deviation from the old site and we can change it if necessary, but I think it is a more sensible default (since there's nothing to show if there aren't any active releases anyway)