851097 - 2 tests are failing on debug builds in ubuntu VM's on mochitest chrome due to assertion counts

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are 2 tests which fail on mochitest-chrome in debug builds only on our EC2 Ubuntu VMs:
12944 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/generic/test/test_selection_underline.html | Assertion count 1 is greater than expected range 0-0 assertions.
13553 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_bug393970.xul | Assertion count 24 is greater than expected range 0-0 assertions.

I can adjust the SimpleTest.expectAssertions() and these will pass (with a TEST-KNOWN-FAIL for the assertion count).  The problem is we need to land the change, then migrate the test over, maybe we could provide a range of expected Assertions to land the code, and when the tests are moved over, we could reduce that range or provide a single value?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

some logs:
32 bit: https://tbpl.mozilla.org/php/getParsedLog.php?id=20625866&tree=Cedar
64 bit: https://tbpl.mozilla.org/php/getParsedLog.php?id=20628868&tree=Cedar

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

ok, test_selection_underline only occured once on a local run (out of 10 total local runs), but this occurs everytime:
412 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/caps/tests/mochitest/test_principal_extendedorigin_appid_appstatus.html | Assertion count 4 is greater than expected range 2-2 assertions.

Comment 3

[Karl Tomlinson (:karlt)]

It is the same assertion happening multiple times in test_principal_extendedorigin_appid_appstatus.html.  Widening the range seems quite reasonable.

INFO -  ###!!! ASSERTION: Empty aExtension parameter!: '!aExtension.IsEmpty()', file ../../../uriloader/exthandler/nsExternalHelperAppService.cpp, line 2722

Don't know what to make of the assertions in test_bug393970.xul:

INFO -  [Parent 2169] ###!!! ASSERTION: A Box's child is constantly growing!!!!!: 'passes < 10', file ../../../../../layout/xul/base/src/nsSprocketLayout.cpp, line 565

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: account for consistent asserts on ubuntu ec2 testers (1.0)

this patch allows us to work on the current fedora testers while allowing us to work on the new ubuntu ec2 testers.  Once we are not running on fedora, we will need to adjust these expected asserts to be the specific amount, not a large range.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 725412 [details] [diff] [review]
account for consistent asserts on ubuntu ec2 testers (1.0)

space after the comma, please.  r=dbaron

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d63f896ab3da

Comment 7

[[e-mail] (:bhearsum)]

I'm going to assume this is fixed or not necessary anymore.