851173 - Can't change encoding for e-mails in TB17 using AppMenu button

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Serg Iv]

Open any message.

AppMenu -> View -> Character Encoding -> Auto-Detect -> anything

Result:
[JavaScript Application]
ReferenceError: BrowserCharsetReload is not defined

AppMenu -> View -> Character Encoding -> More Encodings -> anything

Result:
[JavaScript Application]
ReferenceError: BrowserSetForcedCharacterSet is not defined

Encoding can be changed using the Menu Bar.

http://forums.mozillazine.org/viewtopic.php?f=39&t=2676929

Comment 1

[Joe Sabash [:JoeS1]]

Yes, I'm seeing this on current trunk as well.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Thunderbird/22.0a1 ID:20130313030702 CSet: fab9e5145cd4

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Patch

This didn't work as I used some attributes from FX-AppMenu. With this patch I can change the encoding.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 725730 [details] [diff] [review]
Patch

Review of attachment 725730 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWindowOverlay.xul
@@ +1656,5 @@
>                    label="&charsetMenu.label;"
>                    datasources="rdf:charset-menu"
> +                  ref="NC:MailviewCharsetMenuRoot"
> +                  oncommand="MailMultiplexHandler(event)"
> +                  onpopupshowing="CreateMenu('mailview');UpdateMailMenus()"

Why the reordering here?

Why CreateMenu('browser'), UpdateMailMenus(), CreateMenu('more-menu') instead of the original order?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Mike Conley (:mconley) from comment #3)
> Comment on attachment 725730 [details] [diff] [review]
> Patch
> 
> Review of attachment 725730 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/base/content/mailWindowOverlay.xul
> @@ +1656,5 @@
> >                    label="&charsetMenu.label;"
> >                    datasources="rdf:charset-menu"
> > +                  ref="NC:MailviewCharsetMenuRoot"
> > +                  oncommand="MailMultiplexHandler(event)"
> > +                  onpopupshowing="CreateMenu('mailview');UpdateMailMenus()"
> 
> Why the reordering here?
> 
> Why CreateMenu('browser'), UpdateMailMenus(), CreateMenu('more-menu')
> instead of the original order?

When I implemented it the first time I copied it from FX AppMenu, therefore I used ref="NC:BrowserCharsetMenuRoot" etc. e.g. made to work in FX.

The new ref, oncommand, onpopupshowing and onpopupshown are the ones I found in global/charsetOverlay.xul in TBs omni.ja. And this are the ones which are working in TB.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 725730 [details] [diff] [review]
Patch

Forgot to set r? again.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 725730 [details] [diff] [review]
Patch

Review of attachment 725730 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right! Thanks Richard!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/34a8710a6379

Comment 9

[Alexander L. Slovesnik]

Can this patch be considered for backporting in Thunderbird 17 ESR branch? Manual selection of encoding is important for users in some countries which use several legacy encodings.

Comment 10

[Richard Marti (:Paenglab)]

Comment on attachment 725730 [details] [diff] [review]
Patch

[Approval Request Comment]
This patch changes only calls to already existing functions and should be safe to implement on ESR-17 and as in comment 9 written it could be important for international users.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 725730 [details] [diff] [review]
Patch

a=Standard8

Comment 12

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/ea115886a6f6
https://hg.mozilla.org/releases/comm-beta/rev/165a30811b05

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr17/rev/1834c9586d8f

Comment 14

[Helmut]

Unfortunately this bug is alive in TB 31.0 (build 20140717165725, EN-US) again.
Exactly as described here at the first comment "Serg Iv 2013-03-14 10:22:23 PDT".

Hopefully this will be fixed soon and ... forever;-)
Thanks in advance for your help.

Comment 15

[Richard Marti (:Paenglab)]

Here it works. Have you tested in "Safe Mode" (Help -> Restart with Add-ons disabled...)? If it still happens please open a new bug with exact steps to reproduce. This bug is a long time closed.

Comment 16

[Helmut]

Thanks Richard for the reminder of the safe mode (the ideal first action before complaining).
Yes, now it works!

I disabled each add-on individually and also noticed this:
Priority Switcher 0.16.4 is the odd one and causes this problem here, also already written here:
https://addons.mozilla.org/en-US/thunderbird/addon/priority-switcher/reviews/603200/
Sorry for the confusion. At least the problem is now solved HERE and may avoid further reopenings.

Comment 17

[John Andersen]

Tbird 31.3.0 Windows.

If you select from the File / Edit / View menu
  you will get this error.

If you select from the hamburger menu (three horizontal bars menu) it works and does not error.

I do not have Priority Switcher installed, but If I start in safe mode it works from either menu
location (File menu or hamburger menu).
I have Enigmail, Folder Pane Tools, Google Search for Thunderbird, Lightning, Lookout, Provider for Google Calendar, Toggle Word Wrap, and Google Contacts installed (all up to date).

----> Disabling Google Contacts 0.7.12 removes the error.

But this does not explain why it works from One menu location but not the Other menu location.

Comment 18

[Markus Adrario [:Taraman]]

Attachment: An additional square is visible in the menu with addon activated

Comment 19

[Markus Adrario [:Taraman]]

Attachment: Without plugin, there is one menupopup below char encoding menu

Comment 20

[Markus Adrario [:Taraman]]

Attachment: With plugin, there are 2 menupopups below char encoding menu

Comment 21

[Markus Adrario [:Taraman]]

I stumbled across this issue today in TB 31.6.0 with Google Contacts.

If the addon is active, a small square appears beside the arrow in the charset menuItem (see first screenshot / attachment 8588283 [details])

The DOM-Inspector shows, that if the plugin is activated, a second menupopup element appears directly below the charset menupopup. (attachment 8588284 [details] / attachment 8588286 [details])
The second one has no id, but the "ref = NC:BrowserAutodetMenuRoot" Attribute lets me suppose, that it is a misplaced Autodetect menupopup.

So my guess is, that in the Charset Menu somehow the 
             onpopupshowing="CreateMenu('browser');UpdateMenus(event)"

functions produce a wrong output in this case.

JavaScript Console does not record any errors or warnings though.

Shall we reopen this bug?
To me it looks, like this is not only an addon-problem.

Comment 22

[Richard Marti (:Paenglab)]

This bug is closed since almost 2 years.

Please open a new bug. But if it happens only with Google Contacts, then it is probably more a issue there. The charset menu was changed to no more use rdf (don't remember when) and the extension needs maybe an update for this.