851320 - private-browsing-supported/main.test page-mod on non-private tab | The worker is really non-private - true == false | private-browsing-supported/main.test page-mod on non-private tab | The document is really non-private -true ==false

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

New intermittent failure popping up on OSX debug builds.

TEST-UNEXPECTED-FAIL | private-browsing-supported/main.test page-mod on non-private tab | The worker is really non-private - true == false
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/page-mod.js", line 238, in onReady
    self._createWorker(window);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/page-mod.js", line 249, in _createWorker
    this._emit('attach', worker);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://private-browsing-mode-test-at-jetpack/private-browsing-supported/lib/test-page-mod.js", line 89, in exports["test page-mod on non-private tab"]/pageMod<.onAttach
    assert.ok(!isPrivate(worker), "The worker is really non-private");
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 103, in ok
    operator: "=="
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/harness.js", line 380, in testMessage
    this.trace();
TEST-UNEXPECTED-FAIL | private-browsing-supported/main.test page-mod on non-private tab | The document is really non-private - true == false
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/page-mod.js", line 238, in onReady
    self._createWorker(window);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/page-mod.js", line 249, in _createWorker
    this._emit('attach', worker);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://private-browsing-mode-test-at-jetpack/private-browsing-supported/lib/test-page-mod.js", line 90, in exports["test page-mod on non-private tab"]/pageMod<.onAttach
    assert.ok(!isPrivate(worker.tab), "The document is really non-private");
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 103, in ok
    operator: "=="
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/harness.js", line 380, in testMessage
    this.trace();

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

> on OSX debug builds.

And Windows debug and nondebug...

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This seems very related to bug 834958.

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

It's not strictly related to `bug 834958`; but to the private's test added in the same commit. So basically page-mod's test are using a generic "data:*" as `include` property for their tests. So if there is any tabs opened from other tests with a "data:" url (that is happen quite often in our test) the page-mod will be applied to them too.

I already fixed that error in the `test/addons/private-browsing-supported/test-page-mod.js`, use in `include` the same URL opened by the test itself; it seems that the regular `test-page-mod.js` tests needs to be fixed. too.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

It's actually seems still in `test/addons/private-browsing-supported/test-page-mod.js`, related to "about:buildconfig": most likely, some other test leave this page open for a timing issue. I will try to open a different unique URL and see if it's the case.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/859

Pointer to Github pull-request

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/24bd28d515094ce167697ba1f7312e19d2a73a9a
Bug 851320 - private-browsing-supported/test-page-mod fails

Replaced `about:buildconfig` with a more unique URL. The failure is most likely related to another test that open the same URL but with a different private setting. We already had a similar issue, fixed in the same way.

https://github.com/mozilla/addon-sdk/commit/19f904bd56ee7fcc819999e1e09a6fff3d63b952
Merge pull request #859 from ZER0/page-mod-test/851320

fix Bug 851320 - private-browsing-supported/test-page-mod fails r=@mossop

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/860

Pointer to Github pull-request

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/24109eecee1cb6740dd824cca0e7430fc7a7fd78
Bug 851320 test that opened window is not private when it should not be private

https://github.com/mozilla/addon-sdk/commit/77ecd5b26c3245cebf2de96f9c861df5ce18f80d
Merge pull request #860 from erikvold/851320

Bug 851320 test that opened window is not private when it should not be private r=@ZER0

Comment 9

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/861

Pointer to Github pull-request

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/bd79c14ce244a2ab59e10e8f37c897ceb81f99a5
Bug 851320 - private-browsing-supported/test-page-mod fails

Used the proper open method and ensure everything is close and the window is in the private mode expected.

https://github.com/mozilla/addon-sdk/commit/95c22be219d94bdc4dd91473a0d338c2802abe2c
Merge pull request #861 from ZER0/page-mod-test/851320

Bug 851320 - private-browsing-supported/test-page-mod fails r=@erikvold

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think we fixed this one.

Comment 12

[[github robot]]

Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4c78b6f37cea77dfba812a4e21159b854afc9ab9
Merge pull request #859 from ZER0/page-mod-test/851320

fix Bug 851320 - private-browsing-supported/test-page-mod fails r=@mossop(cherry picked from commit 19f904bd56ee7fcc819999e1e09a6fff3d63b952)

https://github.com/mozilla/addon-sdk/commit/11ff12d0338e0bbee0e6626293d6b3df0958c96e
Merge pull request #860 from erikvold/851320

Bug 851320 test that opened window is not private when it should not be private r=@ZER0(cherry picked from commit 77ecd5b26c3245cebf2de96f9c861df5ce18f80d)

https://github.com/mozilla/addon-sdk/commit/c91f172418e062b0abb8e87a8bef383370207b3f
Merge pull request #861 from ZER0/page-mod-test/851320

Bug 851320 - private-browsing-supported/test-page-mod fails r=@erikvold(cherry picked from commit 95c22be219d94bdc4dd91473a0d338c2802abe2c)