851371 - Change dm.catFile -> dm.pullFile

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

Mozharness uses a now-removed mozdevice method, catFile.  We should change this to pullFile instead.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Change catFile to pullFile,

Comment 2

[William Lachance (:wlach)]

Comment on attachment 725195 [details] [diff] [review]
Change catFile to pullFile,

lgtm

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 725195 [details] [diff] [review]
Change catFile to pullFile,

http://hg.mozilla.org/build/mozharness/rev/c5d31cf1b833

Comment 4

[Jonathan Griffin (:jgriffin)]

I'll spin the other mozdevice fixes off into a separate bug.  The difficulty here is that mozharness depends on mozdevice, but the same mozharness version is used across branches, while the version of mozdevice that may be used in different branches varies. 

This isn't a problem in this case since pullFile has always existed, but I can imagine it causing us big headaches with some future API change.

One solution would be to have mozharness install the version of mozdevice it needs locally, rather than using the version that happens to be in the virtualenv created for whatever harness it's running.

Comment 5

[Jonathan Griffin (:jgriffin)]

Filed a follow-up as bug 851573.

Comment 6

[Aki Sasaki (not active)]

This is in production.

* we could use a requirements file with specific versions, rather than a range; if this were checked into the tree that would allow us to ride the trains
* if we're going to be accessing mozdevice APIs rather than calling an executable, we need to make sure those APIs are supported until they're not used anymore.  I suggest deprecating them and waiting at least one full train cycle (up to 24 weeks) before removing functionality like this.