Mozharness mozdevice fixes

RESOLVED FIXED

Status

Release Engineering
Applications: MozharnessCore
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There are a couple of places where mozharness uses mozdevice incorrectly (since it was written against an older version and some API's have since changed).  According to wlach:

"
Just searching through device.py, I see the following api usage which tries to check return values which no longer exist (since we throw exceptions now, see bug 795456):

https://github.com/escapewindow/mozharness/blob/master/mozharness/mozilla/testing/device.py#L499
https://github.com/escapewindow/mozharness/blob/master/mozharness/mozilla/testing/device.py#L572
"

Comment 1

5 years ago
FTR, that code might be used by "b2g_panda.py" but I don't think we have code actively using it besides b2g_panda.py.

Adding kmoir to keep her in the loop of changes in DeviceMixin (since she is tryin.

Comment 2

5 years ago
(since she is trying to get Android panda jobs to use mozharness).
(Assignee)

Updated

5 years ago
Depends on: 795496
(Assignee)

Updated

5 years ago
Depends on: 795456
No longer depends on: 795496
(Assignee)

Comment 3

5 years ago
Created attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,
Attachment #726292 - Flags: review?(wlachance)
Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

These look like the right adjustments. I am not familiar with this code at all though, so maybe flag someone else for review who is.
Attachment #726292 - Flags: review?(wlachance) → review+
(Assignee)

Comment 5

5 years ago
Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

Or pass on to whomever is most appropriate.
Attachment #726292 - Flags: review?(aki)

Updated

5 years ago
Attachment #726292 - Flags: review?(aki) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

http://hg.mozilla.org/build/mozharness/rev/7599724311e0
Attachment #726292 - Flags: checked-in+

Comment 7

5 years ago
Merged to production.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Updated

4 years ago
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.