Closed Bug 851573 Opened 7 years ago Closed 7 years ago

Mozharness mozdevice fixes

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file)

There are a couple of places where mozharness uses mozdevice incorrectly (since it was written against an older version and some API's have since changed).  According to wlach:

"
Just searching through device.py, I see the following api usage which tries to check return values which no longer exist (since we throw exceptions now, see bug 795456):

https://github.com/escapewindow/mozharness/blob/master/mozharness/mozilla/testing/device.py#L499
https://github.com/escapewindow/mozharness/blob/master/mozharness/mozilla/testing/device.py#L572
"
FTR, that code might be used by "b2g_panda.py" but I don't think we have code actively using it besides b2g_panda.py.

Adding kmoir to keep her in the loop of changes in DeviceMixin (since she is tryin.
(since she is trying to get Android panda jobs to use mozharness).
Depends on: 795496
Depends on: 795456
No longer depends on: 795496
Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

These look like the right adjustments. I am not familiar with this code at all though, so maybe flag someone else for review who is.
Attachment #726292 - Flags: review?(wlachance) → review+
Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

Or pass on to whomever is most appropriate.
Attachment #726292 - Flags: review?(aki)
Attachment #726292 - Flags: review?(aki) → review+
Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

http://hg.mozilla.org/build/mozharness/rev/7599724311e0
Attachment #726292 - Flags: checked-in+
Merged to production.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.