851573 - Mozharness mozdevice fixes

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jonathan Griffin (:jgriffin)]

There are a couple of places where mozharness uses mozdevice incorrectly (since it was written against an older version and some API's have since changed).  According to wlach:

"
Just searching through device.py, I see the following api usage which tries to check return values which no longer exist (since we throw exceptions now, see bug 795456):

https://github.com/escapewindow/mozharness/blob/master/mozharness/mozilla/testing/device.py#L499
https://github.com/escapewindow/mozharness/blob/master/mozharness/mozilla/testing/device.py#L572
"

Comment 1

[Armen [:armenzg]]

FTR, that code might be used by "b2g_panda.py" but I don't think we have code actively using it besides b2g_panda.py.

Adding kmoir to keep her in the loop of changes in DeviceMixin (since she is tryin.

Comment 2

[Armen [:armenzg]]

(since she is trying to get Android panda jobs to use mozharness).

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Update mozdevice calls that presently throw exceptions rather than returning status values,

Comment 4

[William Lachance (:wlach)]

Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

These look like the right adjustments. I am not familiar with this code at all though, so maybe flag someone else for review who is.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

Or pass on to whomever is most appropriate.

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 726292 [details] [diff] [review]
Update mozdevice calls that presently throw exceptions rather than returning status values,

http://hg.mozilla.org/build/mozharness/rev/7599724311e0

Comment 7

[Aki Sasaki (not active)]

Merged to production.