851406 - MozKeyboard initialization fails in emulator with multithreaded image decoding patches applied; Gaia needs updating?

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Joe Drew (not getting mail)]

Attachment: rollup patch

If you apply the rollup patch attached here (I emailed a version of it to Fabrice) and run Try emulator builds on it, you get very frequent errors:

  No permission to use the keyboard API for app://system.gaiamobile.org

This is insane, since the system app has the keyboard permission. *Except* - the Gaia patches in bug 847105 that ostensibly grant the keyboard and system app permission to the keyboard app have not been applied to the Gaia we ship with our emulator.

I suspect (but have not yet proven) that my patches change initialization ordering, which causes the keyboard to be initialized. This would be fine except for the above.

I have relatively conclusively proven that the keyboard isn't being initialized normally on mochitest and crashtest and the like; see this try build: https://tbpl.mozilla.org/?tree=Try&rev=8ebd786a5421

Fabrice tells me that he's going to run my patch against an actual device for more information, but I'm filing this to get more eyes.

Comment 1

[Joe Drew (not getting mail)]

rail/jgriffin, I'm not sure which of you usually builds new emulator builds, but can one of you build a new emulator with an updated gecko for me so that I can run it against try?

Comment 2

[Rail Aliiev [:rail]]

Emulator builds are usually provided by jgriffin. Buildduty can upload them for you so you can push to try. Just ping buildduty or me on IRC.

Comment 3

[Jonathan Griffin (:jgriffin)]

New emulator url:  http://ec2-107-20-108-245.compute-1.amazonaws.com/jenkins/job/b2g-build/1677/artifact/package.zip

Comment 4

[Rail Aliiev [:rail]]

size: 626324746
hash: 8f071f6d8295e1ecb2fbe04ae2f556d0f3617233a96538611b3a4c0f7e81703487c954c60e00c0cfa4245aad29c1f5f0fb9f64be23a7863b97e1f4e7cad1eb9c

Comment 5

[Joe Drew (not getting mail)]

So this does indeed fix the MozKeyboard bug, but unfortunately it makes several other unrelated text-related reftests fail: https://tbpl.mozilla.org/?tree=Try&rev=423b9fd6be30

Comment 6

[Jonathan Griffin (:jgriffin)]

These failures are caused by the emulator update, they also show up in bug 852111.  We'll need someone to investigate them, or we can disable them.  :(

Comment 7

[Joe Drew (not getting mail)]

If we can get someone to investigate this *very soon* we can go ahead without disabling, but I'm betting chances of that are not good . so - Do you want to disable or shall I?

Comment 8

[Jonathan Griffin (:jgriffin)]

cc'ing Jonas.  Jonas, it looks like some code in the emulator has changed at some point which makes some fonts appear differently, which is breaking a lot of reftests.  We need someone to investigate this, or alternately, we need to disable all those failing tests so :joedrew can land his patch, which requires a new emulator be uploaded to buildbot.  Which do you prefer?

Comment 9

[Joe Drew (not getting mail)]

Attachment: update the emulator

This is just an update of the emulator to the version that jgriffin built and ran through try with the font update backed out. It seems to be green!

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 727026 [details] [diff] [review]
update the emulator

lgtm.

$ curl -I http://runtime-binaries.pvt.build.mozilla.org/tooltool/sha512/31e1e74c621b98ee0970ed656636b495c4c90e82060442e8f19d35bc1839e55030736b4aa689c8325f9b9b80aa1cc6b1981dd95b88c8c63ca8e5b0db9957ac0a
HTTP/1.1 200 OK
...
Content-Length: 622597962
...

Comment 11

[Jonathan Griffin (:jgriffin)]

(In reply to Joe Drew (:JOEDREW! \o/) from comment #9)
> Created attachment 727026 [details] [diff] [review]
> update the emulator
> 
> This is just an update of the emulator to the version that jgriffin built
> and ran through try with the font update backed out. It seems to be green!

You should be good to push that.

Comment 12

[Joe Drew (not getting mail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e710a155c75

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2e710a155c75