851473 - Restart dialogues say opposite feature enable/disable things when toggling Private browsing with checkbox or drop-down (Always use private browsing mode / Never remember history)

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[[:Aleksej]]

In Preferences/Options → Privacy → History:

A dialogue appears when toggling Private Browsing mode, saying either of:
* “Nightly must restart to enable this feature.”
* “Nightly must restart to disable this feature.”
It is supposed to be about the PB mode.

* When switching using the “Nightly will:” drop down:
** from “Remember History” to “Never remember history” — it says “enable”.  Correct.  After restarting, browser.privatebrowsing.autostart;true
** from “Never remember history” to “Remember History” — it says “disable”.  Correct.  browser.privatebrowsing.autostart;false

* With “Use custom settings for history”, the box “Always use private browsing mode”:
** when checking the box, Nightly says “disable”.  Incorrect.  browser.privatebrowsing.autostart;true
* when unchecking the box, Nightly says “enable”.  Incorrect.   browser.privatebrowsing.autostart;false

Comment 1

[[:Aleksej]]

2013-03-14-03-09-14-mozilla-central-firefox-22.0a1.en-US.linux-x86_64
and 20.0b5

Comment 2

[Ioana (away)]

This is a Firefox 20 beta 5 regression (it doesn't reproduce on older versions). The obvious culprit is the fix for bug 842290.

Comment 3

[[:Aleksej]]

> The obvious culprit is the fix for bug 842290.

Confirming the regression range includes it:
WFM: 2013-03-07-03-09-26-mozilla-central-firefox-22.0a1.en-US.linux-x86_64
bug: 2013-03-08-03-10-05-mozilla-central-firefox-22.0a1.en-US.linux-x86_64

Comment 4

[Ioana (away)]

Reproducible on the latest beta, nightly, and aurora builds.

Comment 5

[u279076]

Nominating this for tracking given it's a regression introduced late in the Beta cycle.

Comment 6

[(no longer active)]

Attachment: Patch (v1)

We were using the pref value to determine the dialog message, but the pref won't be updated right when you click on the checkbox.  This changes the condition to look at the checked state of the checkbox, which is taken care of by updatePrivacyMicroControls() when you change the drop-down selection.

Comment 7

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d5dcd62f32dd

Comment 8

[(no longer active)]

Comment on attachment 725413 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 842290
User impact if declined: See comment 0
Testing completed (on m-c, etc.): Locally
Risk to taking this patch (and alternatives if risky): Minimal
String or UUID changes made by this patch: None

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d5dcd62f32dd

Comment 10

[bhavana bajaj [:bajaj]]

Requesting QA verification on branches, once the patch lands . Thnx !

Comment 11

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f100301b65b

Comment 12

[u279076]

Ioana, please ensure this gets verified in the latest builds. Thanks.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 725413 [details] [diff] [review]
Patch (v1)

We need this in tomorrow's beta to make sure we can get this verified in time for our final beta next week so please go ahead with uplift asap.

Comment 14

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-beta/rev/92bff35f9d2f

Comment 15

[Ioana (away)]

Tested this issue on the 03/18 Aurora and Nightly, on Windows 7 32bit, on Mac OSX 10.7.5 64bit, and on Ubuntu 12.10 32bit:
- it doesn't reproduce anymore on any of the Nightly builds, nor on the Mac and Linux Auroras;
- it still reproduces on the Windows Aurora builds.

Comment 16

[Ioana (away)]

Verified as fixed on the 03/20 Aurora (20130320062118) and Firefox 20 beta 6 (20130320062118) - Windows 7 32bit, Ubuntu 12.10 32bit and Mac OSX 10.7.5.