851481 - [Dialer] Remove errors in nightly and restore desktop mockuping

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to remove all errors for having it ready for testing in Nightly (really useful for next steps in optimization of Dialer) and for adding test of UI.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 725382 [details]
Pull Request

Can you explain a little bit more why we need to touch the lazy load part?
The description of the bug is rather vague.

Also, wouldn't it be simpler to add the system message handler bit to Kevin's add-on instead of modifying every app?

Comment 3

[Borja Salguero [:borjasalguero]]

Hi Etienne. As you know we are modifying call log for getting a better performance. For making it happens,  I would need that Dialer will be working in my Nightly for adding tests and mockuping the calllog for developing the rest of the functionality, but I've realized that the current code it's not working as expected.
Mainly there are 2 things here:
- System Message Handler errors in Desktop/Nightly (Could you explain better the Kevin's add-on for it? I could use it instead?)
- Lazy Loading. Currently there were some issues (in fact these errors were on the device as well :S) so I've fixed it.

I would like to fix all errors before applying my patch to rendering using the modification of the DB made by Fernando. Thanks!

Comment 4

[Kevin Grandon :kgrandon]

Hi Borja - I believe Etienne was talking about the plugin here: https://github.com/KevinGrandon/Firefox-OS-Runtime

This should fix *most* current errors in nightly, and even give you a semi-working dialier/call log. Worth giving it a shot, but I am ok with either solution :)

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Borja Salguero [:borjasalguero] from comment #3)
> - Lazy Loading. Currently there were some issues (in fact these errors were
> on the device as well :S) so I've fixed it.
> 

What errors?
If we have on-device errors we should have bugs filed for them, and avoid fixing them in a vague desktop-related grab all bug...

Uplifting is already hard enough, I really don't like the idea of creating a dependance between the call log performance work and a desktop-related issue that probably shouldn't be uplifted. Or between a lazy load bug and this bug for that matter.

Can you please file any device bug separately and test Kevin's plugin?