851517 - "Reddit Enhancement Suite" doesn't work on Nightly 22.0a1

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[08xjcec48]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20130315 Firefox/22.0
Build ID: 20130315030943

Steps to reproduce:

Installed https://addons.mozilla.org/en-US/firefox/addon/reddit-enhancement-suite/


Actual results:

It doesn't work anymore since the last couple Nightly updates.


Expected results:

There should be an additional option on Reddit top right options to control RES settings, along with many page changes done by the extesion. It doesn't work at all.

Comment 1

[Matthias Versen [:Matti]]

We are not responsible for third party extensions

Comment 2

[08xjcec48]

But it was working until recently on Nightly, so it was a Nightly change that broke it.

Comment 3

[Matthias Versen [:Matti]]

I would do a regression range search if you provide Steps to reproduce.
I don't know the extension nor reddit.

Note: Some extensions will of course break in one nightly build if a function is changed that this extension used.

Comment 4

[08xjcec48]

Reddit is a website with subforums (subreddits) about different topics. For example, you may like http://reddit.com/r/programming . This extension adds customizations and new features, such as the possibility to filter subreddits one is not interested in.

To reproduce the problem just

1 - Install https://addons.mozilla.org/en-US/firefox/addon/reddit-enhancement-suite/
2 - And go to reddit.com

See a comparison side by side with Chrome to see how many changes should be made to the page (including the gear icon/menu): http://i.imgur.com/YoaPLOo.png

Comment 5

[Matthias Versen [:Matti]]

There is an error at the console while installing the extension: http://pastebin.mozilla.org/2231071
This looks like bug 845063 caused this based on the exception and the regression range

Last good nightly: 2013-02-26
First bad nightly: 2013-02-27

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73f0c5b00572&tochange=e7632ab657e5

marking new because this is an jetpack extension but it seems comment bug851967#c4 could also apply to this extension.

Comment 6

[Brian Crowder]

Is there a way to workaround this, for now?

Comment 7

[Tanner Filip [:tanner]]

A user on Reddit posted this error log: http://www.reddit.com/r/RESissues/comments/1aszuc/res_just_broke_for_me/

I tried using mozregression to find a range, and came up with the same range as mentioned in comment 5.

Comment 8

[Josh Matthews [:jdm]]

Either RES is directly using the old private browsing service (and needs to follow https://developer.mozilla.org/en-US/docs/Updating_addons_broken_by_private_browsing_changes instead), or it needs to repack to use a more recent Addon SDK. Jorge, do we have a developer we can CC?

Comment 9

[Patrick Snape]

@Josh Matthews: RES developer here (though not Steve Sobel, the primary developer and owner of RES). Had a look at those listed changes and can confirm we don't use any of those interfaces. It seems requesting the tabs permission invokes the privatebrowsing interface:

http://www.reddit.com/r/RESissues/comments/1aszuc/res_just_broke_for_me/

Any idea how this can be circumvented?

Comment 10

[Josh Matthews [:jdm]]

In that case, as I mentioned, you need to repack RES using a more recent version of the addon SDK.

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Clearing needinfo. Thank you for the quick response, Patrick :)

Comment 12

[Steve Sobel]

Sorry for the slow response on my part guys -- was CC'ed and following but was in a class all last week and super busy outside of that as well...

In any case, next version of RES will be packed with Addon SDK 1.14 and should come out soon assuming review doesn't take long!

Comment 13

[Steve Sobel]

sorry one more update: I got a message from a user on Reddit saying they already tried compiling with the latest SDK and it still doesn't work.

I haven't confirmed this myself and may not get to look today - but I have no reason not to believe that user.

Comment 14

[Patrick Snape]

The error caused by the new addon SDK is a different one - to do with mozIAsyncHistory.

Just to clarify- I have rebuilt using the latest addon SDK and replaced our usage of nsiGlobalHistory2 with mozIAsyncHistory and all appears OK on Firefox Stable and Nightly (for history features at least).

Comment 15

[08xjcec48]

This extension works normally on the latest version of Firefox. Since I was the one who opened this thread, now I'm marking ir as "Resolved - Invalid" to close it.