Closed
Bug 851966
Opened 11 years ago
Closed 11 years ago
StreamBuffer::ForgetUpTo is horribly inefficient
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
|
134.34 KB,
image/png
|
Details | |
|
9.59 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Profile
In a profile that I have with a lot of Web Audio buffer source nodes playing, we can spend about 50% of the total time in MSGImpl::UpdateCurrentTime, with a 30% of the total time in StreamBuffer::ForgetUpTo.
|
Assignee | |
Comment 1•11 years ago
|
||
I had to store the enum on MediaStreamGraph in order to avoid an #include hell which resulted in trying to store it on AudioNodeStream. :(
Attachment #725953 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/19e6f5093cad
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/19e6f5093cad
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
|
Assignee | |
Comment 4•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•