852014 - Defect - Issues downloading and installing msi

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Shell, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

When attempting to download and install a plugin that is needed to play QuakeLive from the browser, an error occurs stating that there has been a "Download Error". This works without any issues using Desktop Firefox. Reproduced the issue every single time using the Firefox Metro build.

- I've attached a screenshot the illustrates the problem.

Tried going through the Firefox Metro options to see if there could be something preventing the plugin to install correctly, but couldn't find anything.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to http://www.quakelive.com
3) You'll need to create an account (its free)
4) Once you have created the account, you will need to install (this is where the issue occurs)

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Attachment: Download Error

Comment 2

[Brian R. Bondy [:bbondy]]

Plugins won't be supported in Metro v1 but I think the download issue might be more generic and should be handled better.

Comment 3

[Jim Mathies [:jimm]]

I wonder if this is specific to msi files or more general.

Comment 4

[Brian R. Bondy [:bbondy]]

probably general launching applications that are downloaded from within external app handling code.

Comment 5

[Brian R. Bondy [:bbondy]]

Suggestion for iteration 5

Comment 6

[Brian R. Bondy [:bbondy]]

Please remove from it5 if you disagree

Comment 7

[Marco Mucci [:MarcoM]]

Formatted as a defect for iteration #5.

Comment 8

[juan becerra [:juanb]]

I'm not able to download installers like the ones found in nightly.mozilla.org, but I can download video clips and PDFs. I filed bug 856202 which might be a dupe of this.

Comment 9

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

So basically we were trying to launch the msi file instead of downloading it. When launching it, it fails on this code which just checks if it's an executable and returns an error.  (EXE and MSI are executables according to that function):
http://dxr.mozilla.org/mozilla-central/uriloader/exthandler/win/nsMIMEInfoWin.cpp#l40

To fix we just need to always save if it's an executable file.

Comment 10

[Brian R. Bondy [:bbondy]]

The UI is changing with the download app bar stuff but I just wanted to temporarily tweak it in the meantime so it doesn't look like an error (since it's not) when downloading something.

Comment 11

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 733721 [details] [diff] [review]
Patch v1.

Review of attachment 733721 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 12

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/855ddcd081e8

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/855ddcd081e8

Comment 14

[raymond [:retornam] (inactive)]

Tested using 
April 8th, 2012  built from http://hg.mozilla.org/mozilla-central/rev/b0d842380959

After tapping both the download link and the notification to show the Download folder in metro mode, nothing else happens thus the user cannot tell whether the download is done.  I'm re-opening this bug because of this.

Comment 15

[Brian R. Bondy [:bbondy]]

What you are describing is a dupe of bug 856202 which should be landing today.

Comment 16

[Brian R. Bondy [:bbondy]]

Please re-verify after bug 856202 lands, but since you even get to that point now I suspect this can be verified.

Comment 17

[raymond [:retornam] (inactive)]

Hi Brian,
I'll leave this open until Bug 856202 is fixed. Thanks

Comment 18

[raymond [:retornam] (inactive)]

Verified fixed  on April 10th, 2013  built from http://hg.mozilla.org/mozilla-central/rev/9db46ddfb517

I was able to download and install multiple msi packages including the one from http://quakelive.com

Comment 19

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.