Closed Bug 852135 Opened 12 years ago Closed 12 years ago

Move element.attributes to WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 3 obsolete files)

Part a: Reindent some code in nsDOMAttributeMap
8.99 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part a -w
3.41 KB, patch
Details | Diff | Splinter Review
Part b: Get rid of some explicit namespace qualifications
3.71 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part c: Implement the remainder of the WebIDL API
17.03 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part d: Move to WebIDL bindings, remove CI and QS
16.28 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Patch v1 (obsolete) — — Splinter Review
Attachment #729437 - Flags: review?(khuey)
Attached patch Patch v1.1 (obsolete) — — Splinter Review
Attachment #729437 - Attachment is obsolete: true
Attachment #729437 - Flags: review?(khuey)
Attachment #732225 - Flags: review?(khuey)
Attached patch Patch v1.2 (obsolete) — — Splinter Review
Attachment #732225 - Attachment is obsolete: true
Attachment #732225 - Flags: review?(khuey)
Attachment #734285 - Flags: review?(khuey)
Comment on attachment 734285 [details] [diff] [review] Patch v1.2 Going to wait until Attr lands.
Attachment #734285 - Flags: review?(khuey)
Attachment #734285 - Attachment is obsolete: true
Attachment #737234 - Flags: review?(khuey)
Attached patch Part a -w — — Splinter Review
Comment on attachment 737234 [details] [diff] [review] Part a: Reindent some code in nsDOMAttributeMap r=me
Attachment #737234 - Flags: review?(khuey) → review+
Comment on attachment 737236 [details] [diff] [review] Part b: Get rid of some explicit namespace qualifications r=me
Attachment #737236 - Flags: review?(khuey) → review+
Comment on attachment 737238 [details] [diff] [review] Part c: Implement the remainder of the WebIDL API r=me
Attachment #737238 - Flags: review?(khuey) → review+
Comment on attachment 737239 [details] [diff] [review] Part d: Move to WebIDL bindings, remove CI and QS WrapObject takes a handle for the scope now. r=me with that
Attachment #737239 - Flags: review?(khuey) → review+
Depends on: 868265
Depends on: 868834
Depends on: 869796
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: