868834 - Clicking the letter for a failed job on tbpl intermittently loads the log from the link href rather than triggering the onclick

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Phil Ringnalda (:philor)]

According to my bisecting, this is a regression from http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=a6104e0e5a2c, out of which bug 852135 seems most likely.

STR:
1. Load https://tbpl.mozilla.org/?tree=Try&onlyunstarred=1 (you need lots of failure, and Try is where you'll find it)
2. Click on the orange/red letters until suddenly a log loads

The onclick is stuck on by jQuery in https://hg.mozilla.org/webtools/tbpl/file/9af3474be6d7/js/UserInterface.js#l109 but roughly speaking the letters are <a href="php/getParsedLog.php?id=22609894&amp;tree=Mozilla-Inbound" onclick="dontloadthatlog()">R</a>.

Comment 1

[Phil Ringnalda (:philor)]

Less bothersome but also frequent: clicking the "add a comment" link will load the pointless href="#" instead of doing the onclick.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ms2ger?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Philor, could you try a build from https://tbpl.mozilla.org/?tree=Try&rev=13c040759dbb ?

Comment 4

[Phil Ringnalda (:philor)]

I'll keep using those builds (for Science!), but I've already gone far longer using them without hitting a single instance of this than I've gone with any affected build, so I'm pretty sure that does get rid of the problem.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Backout

I guess that's what we're doing for now, then.

Comment 6

[Boris Zbarsky [:bzbarsky]]

If I drop the usesBeforeCompile for Ion from 1000 to 100, I get this bug on about the third click.

Then if I also disable the missing-property IC on gets, the bug disappears completely.

So I am willing to bet money this is bug 869040.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 746576 [details] [diff] [review]
Backout

Let's fix bug 869040 instead.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Oh, and turning off ion.content in about:config of course also makes the bug go away.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Philor, please WFM if that fixed it.

Comment 10

[Phil Ringnalda (:philor)]

Yep.