Clicking the letter for a failed job on tbpl intermittently loads the log from the link href rather than triggering the onclick

RESOLVED WORKSFORME

Status

()

Core
DOM: Core & HTML
RESOLVED WORKSFORME
5 years ago
5 years ago

People

(Reporter: philor, Unassigned)

Tracking

({regression})

Trunk
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
According to my bisecting, this is a regression from http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=a6104e0e5a2c, out of which bug 852135 seems most likely.

STR:
1. Load https://tbpl.mozilla.org/?tree=Try&onlyunstarred=1 (you need lots of failure, and Try is where you'll find it)
2. Click on the orange/red letters until suddenly a log loads

The onclick is stuck on by jQuery in https://hg.mozilla.org/webtools/tbpl/file/9af3474be6d7/js/UserInterface.js#l109 but roughly speaking the letters are <a href="php/getParsedLog.php?id=22609894&amp;tree=Mozilla-Inbound" onclick="dontloadthatlog()">R</a>.
(Reporter)

Comment 1

5 years ago
Less bothersome but also frequent: clicking the "add a comment" link will load the pointless href="#" instead of doing the onclick.
Ms2ger?
Assignee: nobody → Ms2ger
Philor, could you try a build from https://tbpl.mozilla.org/?tree=Try&rev=13c040759dbb ?
(Reporter)

Updated

5 years ago
Flags: needinfo?(philringnalda)
(Reporter)

Comment 4

5 years ago
I'll keep using those builds (for Science!), but I've already gone far longer using them without hitting a single instance of this than I've gone with any affected build, so I'm pretty sure that does get rid of the problem.
Flags: needinfo?(philringnalda)
Created attachment 746576 [details] [diff] [review]
Backout

I guess that's what we're doing for now, then.
Attachment #746576 - Flags: review?(bzbarsky)
If I drop the usesBeforeCompile for Ion from 1000 to 100, I get this bug on about the third click.

Then if I also disable the missing-property IC on gets, the bug disappears completely.

So I am willing to bet money this is bug 869040.
Depends on: 869040
Comment on attachment 746576 [details] [diff] [review]
Backout

Let's fix bug 869040 instead.
Attachment #746576 - Flags: review?(bzbarsky) → review-
Oh, and turning off ion.content in about:config of course also makes the bug go away.
Philor, please WFM if that fixed it.
Assignee: Ms2ger → nobody
Flags: needinfo?(philringnalda)
(Reporter)

Comment 10

5 years ago
Yep.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(philringnalda)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.