test_image_layers.html doesn't wait for its secondary image's onload

RESOLVED FIXED in mozilla22

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

Trunk
mozilla22
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 726497 [details] [diff] [review]
wait for onload and force a paint

Matt and I talked a bit about this. This patch seems like it'll fix it; I'll run it through try some to see if it does.
Attachment #726497 - Flags: review?(matt.woodrow)
Attachment #726497 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 726961 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Still occasionally faily; perhaps this will help.
Attachment #726961 - Flags: review?(matt.woodrow)
Comment on attachment 726961 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Review of attachment 726961 [details] [diff] [review]:
-----------------------------------------------------------------

Using nsDOMWindowUtils::isMozAfterPaintPending would be better, but I guess this should work.
Attachment #726961 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 726998 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

ooh, good idea
Attachment #726961 - Attachment is obsolete: true
Attachment #726998 - Flags: review?(matt.woodrow)
Comment on attachment 726998 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Review of attachment 726998 [details] [diff] [review]:
-----------------------------------------------------------------

Lets hope this one works!
Attachment #726998 - Flags: review?(matt.woodrow) → review+
Created attachment 727014 [details] [diff] [review]
Alternative patch to let the reftest harness handle this

This takes advantage of the fact that the reftest harness already has code to wait until all paints are flushed.

It just adds an annotation to mark elements that shouldn't be painted between when the 'MozReftestInvalidate' callback is called, and the end of the test.

Entirely undocumented and untested. :)
Depends on: 852850

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4a24d7b3126f
https://hg.mozilla.org/mozilla-central/rev/3ec52a8caf73
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 852997
You need to log in before you can comment on or make changes to this bug.