Closed Bug 852413 Opened 9 years ago Closed 9 years ago

test_image_layers.html doesn't wait for its secondary image's onload

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: joe, Assigned: joe)

References

Details

Attachments

(3 files, 1 obsolete file)

Matt and I talked a bit about this. This patch seems like it'll fix it; I'll run it through try some to see if it does.
Attachment #726497 - Flags: review?(matt.woodrow)
Attachment #726497 - Flags: review?(matt.woodrow) → review+
Still occasionally faily; perhaps this will help.
Attachment #726961 - Flags: review?(matt.woodrow)
Comment on attachment 726961 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Review of attachment 726961 [details] [diff] [review]:
-----------------------------------------------------------------

Using nsDOMWindowUtils::isMozAfterPaintPending would be better, but I guess this should work.
Attachment #726961 - Flags: review?(matt.woodrow) → review+
ooh, good idea
Attachment #726961 - Attachment is obsolete: true
Attachment #726998 - Flags: review?(matt.woodrow)
Comment on attachment 726998 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Review of attachment 726998 [details] [diff] [review]:
-----------------------------------------------------------------

Lets hope this one works!
Attachment #726998 - Flags: review?(matt.woodrow) → review+
This takes advantage of the fact that the reftest harness already has code to wait until all paints are flushed.

It just adds an annotation to mark elements that shouldn't be painted between when the 'MozReftestInvalidate' callback is called, and the end of the test.

Entirely undocumented and untested. :)
Depends on: 852850
Depends on: 852997
You need to log in before you can comment on or make changes to this bug.