852413 - test_image_layers.html doesn't wait for its secondary image's onload

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Joe Drew (not getting mail)]

Attachment: wait for onload and force a paint

Matt and I talked a bit about this. This patch seems like it'll fix it; I'll run it through try some to see if it does.

Comment 1

[Joe Drew (not getting mail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a24d7b3126f

Comment 2

[Joe Drew (not getting mail)]

Attachment: wait for onload and paints to finish, then force another paint

Still occasionally faily; perhaps this will help.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 726961 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Review of attachment 726961 [details] [diff] [review]:
-----------------------------------------------------------------

Using nsDOMWindowUtils::isMozAfterPaintPending would be better, but I guess this should work.

Comment 4

[Joe Drew (not getting mail)]

Attachment: wait for onload and paints to finish, then force another paint

ooh, good idea

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 726998 [details] [diff] [review]
wait for onload and paints to finish, then force another paint

Review of attachment 726998 [details] [diff] [review]:
-----------------------------------------------------------------

Lets hope this one works!

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Alternative patch to let the reftest harness handle this

This takes advantage of the fact that the reftest harness already has code to wait until all paints are flushed.

It just adds an annotation to mark elements that shouldn't be painted between when the 'MozReftestInvalidate' callback is called, and the end of the test.

Entirely undocumented and untested. :)

Comment 7

[Joe Drew (not getting mail)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3ec52a8caf73

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a24d7b3126f
https://hg.mozilla.org/mozilla-central/rev/3ec52a8caf73