BaselineCompiler: Fix stack check to handle interrupts too

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Posted patch PatchSplinter Review
When the stack check emitted at the function prologue fails, we check for over-recursion, but we should also check for interrupts (we set ionStackLimit to -1 to interrupt JIT code).

The patch fixes this (calls the same function we call from Ion) and adds a testcase that fails without the patch.
Attachment #726566 - Flags: review?(kvijayan)
Comment on attachment 726566 [details] [diff] [review]
Patch

Review of attachment 726566 [details] [diff] [review]:
-----------------------------------------------------------------

Good call on changing this away from an IC, it makes more sense this way anyway.
Attachment #726566 - Flags: review?(kvijayan) → review+
Assignee

Comment 2

6 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/ff681c5eadaf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.