Closed
Bug 852472
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: Fix stack check to handle interrupts too
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
5.10 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
When the stack check emitted at the function prologue fails, we check for over-recursion, but we should also check for interrupts (we set ionStackLimit to -1 to interrupt JIT code).
The patch fixes this (calls the same function we call from Ion) and adds a testcase that fails without the patch.
Attachment #726566 -
Flags: review?(kvijayan)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 726566 [details] [diff] [review]
Patch
Review of attachment 726566 [details] [diff] [review]:
-----------------------------------------------------------------
Good call on changing this away from an IC, it makes more sense this way anyway.
Attachment #726566 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•