Closed Bug 852534 Opened 7 years ago Closed 7 years ago

Remove GRE_MODULE from Makefile.in's

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file, 1 obsolete file)

Many Makefile.in's still set GRE_MODULE=1, even though that variable no longer has any affect on the build. All references to GRE_MODULE should be removed.
Attachment #726894 - Flags: review?(gps)
Comment on attachment 726894 [details] [diff] [review]
Remove GRE_MODULE from Makefile.in

Review of attachment 726894 [details] [diff] [review]:
-----------------------------------------------------------------

Won't this bit rot the patches in bug 844654? Anyway, this looks good. I love killing cargo culted cruft.
Attachment #726894 - Flags: review?(gps) → review+
Attachment #726894 - Attachment is obsolete: true
Attachment #727697 - Flags: review?
Attachment #727697 - Flags: review? → review?(gps)
Comment on attachment 727697 [details] [diff] [review]
Bug 852534 - Remove GRE_MODULE from Makefile.in

Review of attachment 727697 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #727697 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0dc803fc4b5
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla22
https://hg.mozilla.org/mozilla-central/rev/c0dc803fc4b5
Assignee: nobody → mshal
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 854536
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.