Last Comment Bug 852534 - Remove GRE_MODULE from Makefile.in's
: Remove GRE_MODULE from Makefile.in's
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla22
Assigned To: Michael Shal [:mshal]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 854536
  Show dependency treegraph
 
Reported: 2013-03-19 07:45 PDT by Michael Shal [:mshal]
Modified: 2013-03-25 12:28 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove GRE_MODULE from Makefile.in (73.43 KB, patch)
2013-03-19 14:23 PDT, Michael Shal [:mshal]
gps: review+
Details | Diff | Splinter Review
Bug 852534 - Remove GRE_MODULE from Makefile.in (63.52 KB, patch)
2013-03-21 08:41 PDT, Michael Shal [:mshal]
gps: review+
Details | Diff | Splinter Review

Description Michael Shal [:mshal] 2013-03-19 07:45:33 PDT
Many Makefile.in's still set GRE_MODULE=1, even though that variable no longer has any affect on the build. All references to GRE_MODULE should be removed.
Comment 1 Michael Shal [:mshal] 2013-03-19 14:23:16 PDT
Created attachment 726894 [details] [diff] [review]
Remove GRE_MODULE from Makefile.in
Comment 2 Gregory Szorc [:gps] 2013-03-19 14:28:08 PDT
Comment on attachment 726894 [details] [diff] [review]
Remove GRE_MODULE from Makefile.in

Review of attachment 726894 [details] [diff] [review]:
-----------------------------------------------------------------

Won't this bit rot the patches in bug 844654? Anyway, this looks good. I love killing cargo culted cruft.
Comment 3 Michael Shal [:mshal] 2013-03-21 08:41:49 PDT
Created attachment 727697 [details] [diff] [review]
Bug 852534 - Remove GRE_MODULE from Makefile.in
Comment 4 Gregory Szorc [:gps] 2013-03-21 10:35:37 PDT
Comment on attachment 727697 [details] [diff] [review]
Bug 852534 - Remove GRE_MODULE from Makefile.in

Review of attachment 727697 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Comment 6 Ed Morley [:emorley] 2013-03-22 07:10:02 PDT
https://hg.mozilla.org/mozilla-central/rev/c0dc803fc4b5

Note You need to log in before you can comment on or make changes to this bug.