Closed
Bug 852534
Opened 13 years ago
Closed 13 years ago
Remove GRE_MODULE from Makefile.in's
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: mshal, Assigned: mshal)
References
Details
Attachments
(1 file, 1 obsolete file)
|
63.52 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Many Makefile.in's still set GRE_MODULE=1, even though that variable no longer has any affect on the build. All references to GRE_MODULE should be removed.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #726894 -
Flags: review?(gps)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 726894 [details] [diff] [review]
Remove GRE_MODULE from Makefile.in
Review of attachment 726894 [details] [diff] [review]:
-----------------------------------------------------------------
Won't this bit rot the patches in bug 844654? Anyway, this looks good. I love killing cargo culted cruft.
Attachment #726894 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #726894 -
Attachment is obsolete: true
Attachment #727697 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #727697 -
Flags: review? → review?(gps)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 727697 [details] [diff] [review]
Bug 852534 - Remove GRE_MODULE from Makefile.in
Review of attachment 727697 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #727697 -
Flags: review?(gps) → review+
|
|
||
Comment 5•13 years ago
|
||
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla22
|
|
||
Comment 6•13 years ago
|
||
Assignee: nobody → mshal
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•