852539 - In the main tile view, remove the right to left transition when tapping on the playlists, artists or album tabs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Rob MacDonald [:robmac]]

From the initial tile view, there is a right to left transition immediately after tapping any of the bottom tabs (playlists, albums, artists). 

In this instance, there should be no transition, as it suggests going deeper in the hierarchy, which is not the case.

Comment 1

[Hema Koka [:hema]]

I would like to assign this to one of the newbies as a starter bug. Seems straightforward to fix.

Comment 2

[Sushant Hiray [:sushant]]

Hi!
I'm a newbie and would like to work on this bug.
Could you help me start?

Regards,
Sushant

Comment 3

[Hema Koka [:hema]]

Adding Dominic to help you get started.

Comment 4

[Nicolae Surdu]

I hope this is not considered rude or something, but I'm also new around here and I see that there is no activity on this ticket for a while.

I've took a shot at fixing this bug here: https://github.com/postal2600/gaia/commit/4704a789f15f4aa8452226d2e2aca7bd26b1a207

Can anyone please review my changes and help me thru the process until creating a pull request ?

Thank you!

Comment 5

[Nicolae Surdu]

Attachment: Proposed patch for this bug

Comment 6

[Nicolae Surdu]

Please ignore link in Comment 4, I didn't found/read at the time the rules about properly submitting a patch :(

Comment 7

[Dominic Kuo [:dkuo]]

Comment on attachment 781562 [details] [review]
Proposed patch for this bug

Nicolae,

Thanks for contributing this patch, and apologize for keeping you waiting for the review.
After I pulled and tested your patch, I found the search ui in listView is corrupted, that's probably because one of the views is hidden and breaks the ui, or it's the workaround of bug 857674 caused this. I haven't take a deep look on it because I am working on the other blockers. If you need help, feel free to needinfo me and we can discuss with the comments, thanks.

Comment 8

[Jaison Justus]

is this bug still open?

Comment 9

[Dominic Kuo [:dkuo]]

Fixed in parts of bug 1055049.