852560 - Bugzilla cannot be installed with MySQL 5.6, because the have_innodb variable no longer exists ("InnoDB is disabled in your MySQL installation")

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[:glob ✱]

from http://stackoverflow.com/q/15359467/953

we do:

> my ($innodb_on) = @{$self->selectcol_arrayref(
>     q{SHOW VARIABLES LIKE '%have_innodb%'}, {Columns=>[2]})};
> if ($innodb_on ne 'YES') {
>     die install_string('mysql_innodb_disabled');
> }

according to http://bugs.mysql.com/bug.php?id=63383 have_innodb was removed in mysql 5.6, and we should be using SHOW ENGINES instead.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

This syntax is supported by all versions of MySQL 5.x.

Comment 2

[Frédéric Buclin]

We will take it for 4.0 despite it's not a security bug, because 4.0 is still far from EOL and MySQL 5.6 already reached GA.

Comment 3

[:glob ✱]

Comment on attachment 726803 [details] [diff] [review]
patch, v1

r=glob

Comment 4

[Frédéric Buclin]

On checkin, I replaced /^YES|DEFAULT$/ by /^(YES|DEFAULT)$/.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/DB/Mysql.pm
Committed revision 8597.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/DB/Mysql.pm
Committed revision 8536.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/DB/Mysql.pm
Committed revision 8198.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/DB/Mysql.pm
Committed revision 7748.