Bugzilla cannot be installed with MySQL 5.6, because the have_innodb variable no longer exists ("InnoDB is disabled in your MySQL installation")

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Database
--
critical
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glob, Assigned: Frédéric Buclin)

Tracking

Bugzilla 4.0
Bug Flags:
approval +
approval4.4 +
blocking4.4 +
approval4.2 +
blocking4.2.6 +
approval4.0 +
blocking4.0.11 +

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
from http://stackoverflow.com/q/15359467/953

we do:

> my ($innodb_on) = @{$self->selectcol_arrayref(
>     q{SHOW VARIABLES LIKE '%have_innodb%'}, {Columns=>[2]})};
> if ($innodb_on ne 'YES') {
>     die install_string('mysql_innodb_disabled');
> }

according to http://bugs.mysql.com/bug.php?id=63383 have_innodb was removed in mysql 5.6, and we should be using SHOW ENGINES instead.
(Assignee)

Comment 1

4 years ago
Created attachment 726803 [details] [diff] [review]
patch, v1

This syntax is supported by all versions of MySQL 5.x.
Assignee: database → LpSolit
Status: NEW → ASSIGNED
Attachment #726803 - Flags: review?(glob)
(Assignee)

Comment 2

4 years ago
We will take it for 4.0 despite it's not a security bug, because 4.0 is still far from EOL and MySQL 5.6 already reached GA.
Flags: blocking4.4+
Flags: blocking4.2.6+
Flags: blocking4.0.11+
Summary: unable to install bugzilla with mysql 5.6 - "InnoDB is disabled in your MySQL installation" → Bugzilla cannot be installed with MySQL 5.6, because the have_innodb variable no longer exists ("InnoDB is disabled in your MySQL installation")
Target Milestone: --- → Bugzilla 4.0
(Reporter)

Comment 3

4 years ago
Comment on attachment 726803 [details] [diff] [review]
patch, v1

r=glob
Attachment #726803 - Flags: review?(glob) → review+
(Reporter)

Updated

4 years ago
Flags: approval?
Flags: approval4.4?
Flags: approval4.2?
Flags: approval4.0?
(Assignee)

Updated

4 years ago
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval4.2?
Flags: approval4.2+
Flags: approval4.0?
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 4

4 years ago
On checkin, I replaced /^YES|DEFAULT$/ by /^(YES|DEFAULT)$/.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/DB/Mysql.pm
Committed revision 8597.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/DB/Mysql.pm
Committed revision 8536.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/DB/Mysql.pm
Committed revision 8198.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/DB/Mysql.pm
Committed revision 7748.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.