852569 - Cannot uninstall provider when social is disabled

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Matthew Phillips]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:21.0) Gecko/20130318 Firefox/21.0
Build ID: 20130318042013

Steps to reproduce:

1) I enabled Facebook Messenger.
2) I disabled Facebook Messenger ("turn off")
3) I attempted to remove Facebook Messenger.

Tested on OSX Lion 10.7.5


Actual results:

There was no prompt to remove it.

If Facebook Messenger is enabled when you try to remove it, it will work.


Expected results:

Should have confirmed that I wanted to remove it.

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

Arrg, fail on my Side for not reading properly :-/.

Comment 3

[Shane Caraveo (:mixedpuppy)]

not an issue in 22 since uninstall has changed, reproducible in 21.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: fix fx21 uninstall

This patch can apply to fx22, but the problem is primarily with 21 since we've changed the uninstall process.  I'm fixing uninstall a different way in 22.  If the patch is good, need a= for aurora.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 729851 [details] [diff] [review]
fix fx21 uninstall

Having Social.provider || Social.defaultProvider in a bunch of places seems kind of gross, but I guess given the changes from bug 821262 it's kind of unavoidable. This looks good to me but I think Mark is closer to this code now.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 729851 [details] [diff] [review]
fix fx21 uninstall

Review of attachment 729851 [details] [diff] [review]:
-----------------------------------------------------------------

I guess 'Social.provider || Social.defaultProvider' could just be written as Social.defaultProvider, but given we aren't doing that everywhere else, this makes sense.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 729851 [details] [diff] [review]
fix fx21 uninstall

[Approval Request Comment]
User impact if declined: unable to remove facebook without first reenabling facebook
Testing completed (on m-c, etc.): manual
Risk to taking this patch (and alternatives if risky): annoyed users.  only affects social
String or IDL/UUID changes made by this patch: none

may need to move to beta approval depending on whether we get to this before merge.

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 729851 [details] [diff] [review]
fix fx21 uninstall

low risk patch, user will not be able to to remove FB messenger when its turned off.

Comment 9

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28ff0e110387

Comment 10

[u279076]

Added to my queue for Firefox 21b1 sign off.

Comment 11

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Removing the Social sidebar works fine with it turned off and on.