852576 - Monocle positioning problems when transitioning from caret to drag selection

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

Not sure what causes this, maybe be something in custom dragger. When we swap out a caret monocle for a drag monocle, the monocle image is adjusted down _monocleYHitTextAdjust. Also the starting monocle is adjusted up by the same.

Comment 1

[Jim Mathies [:jimm]]

Thought this was addressed, but it's not.

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

Slight tweak to the transition phase of this. Sending a markerDragStart and markerDragMove wasn't working quite right. After markerDragStart fires, SelectionHandler sends back updated monocle positions for *both* monocles. 

Normally during a drag you only update the monocle that isn't being dragged, which prevents the image from getting repositioned underneath your finger. So this patch adds a new 'SwitchMode' message that replace the call to markerDragStart, which gets SelectionHandler set up properly and only updates the monocle that isn't getting dragged.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 727862 [details] [diff] [review]
patch

Review of attachment 727862 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/contenthandlers/SelectionHandler.js
@@ +1050,5 @@
>        break;
>  
> +      case "Browser:SwitchMode":
> +        this._onSwitchMode(json.newMode, json.change, json.xPos, json.yPos);
> +      break;

Whitespace nit: This "break" and the ones above it are indented differently than in most of our code.

Comment 5

[Jim Mathies [:jimm]]

> Whitespace nit: This "break" and the ones above it are indented differently
> than in most of our code.

Fixed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d7a01a43fe4

Comment 6

[Jim Mathies [:jimm]]

argh, at least I thought it was. I'll add it to the patch in bug 853604.

Comment 7

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/6d7a01a43fe4