Closed Bug 852792 Opened 7 years ago Closed 7 years ago

load sources from the `sourcesContent` field in a source map, if available

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

The `sourcesContent` field in a source map allows devs to put the contents of source files which are not exposed by any public url directly into the source map. We should load the sources from there if an entry for a given source exists there.
Attached patch v1 (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=9fb00b40ba8d

Pretty simple, easy, straight forward. Should be a quick and easy to review as well!
Assignee: nobody → nfitzgerald
Attachment #746192 - Flags: review?(past)
Comment on attachment 746192 [details] [diff] [review]
v1

Forgot that Panos is out for the week...
Attachment #746192 - Flags: review?(past) → review?(rcampbell)
Comment on attachment 746192 [details] [diff] [review]
v1

Review of attachment 746192 [details] [diff] [review]:
-----------------------------------------------------------------

looks fine
Attachment #746192 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
https://tbpl.mozilla.org/?tree=Fx-Team&rev=4dbd432e7667
https://hg.mozilla.org/integration/fx-team/rev/6ebf2274acf5

Although: "CLOSED. BuiltBot issues: jobs don't seem to be showing up; tbpl fails to finish loading; retriggers not working;."
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Backed out for xpcshell bustage
https://hg.mozilla.org/integration/fx-team/rev/b80fd5c9f47a

https://tbpl.mozilla.org/php/getParsedLog.php?id=22857908&tree=Fx-Team

I got oranged locally with either this or bug 852792 in, so I backed them both out.
Whiteboard: [fixed-in-fx-team]
That last comment should read: "I got oranges locally with either this or bug 865252 in, so I backed them both out."
Attached patch v1.1Splinter Review
Rebased to use |attachTestTabAndResume| since the alternative is no longer available.
Attachment #746192 - Attachment is obsolete: true
Whiteboard: [land-in-fx-team]
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Attachment #748998 - Attachment is patch: true
Attachment #748998 - Attachment mime type: text/x-patch → text/plain
https://hg.mozilla.org/mozilla-central/rev/fa63467ea330
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.