852792 - load sources from the `sourcesContent` field in a source map, if available

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The `sourcesContent` field in a source map allows devs to put the contents of source files which are not exposed by any public url directly into the source map. We should load the sources from there if an entry for a given source exists there.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=9fb00b40ba8d

Pretty simple, easy, straight forward. Should be a quick and easy to review as well!

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 746192 [details] [diff] [review]
v1

Forgot that Panos is out for the week...

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 746192 [details] [diff] [review]
v1

Review of attachment 746192 [details] [diff] [review]:
-----------------------------------------------------------------

looks fine

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=4dbd432e7667
https://hg.mozilla.org/integration/fx-team/rev/6ebf2274acf5

Although: "CLOSED. BuiltBot issues: jobs don't seem to be showing up; tbpl fails to finish loading; retriggers not working;."

Comment 5

[Joe Walker [:jwalker]]

Backed out for xpcshell bustage
https://hg.mozilla.org/integration/fx-team/rev/b80fd5c9f47a

https://tbpl.mozilla.org/php/getParsedLog.php?id=22857908&tree=Fx-Team

I got oranged locally with either this or bug 852792 in, so I backed them both out.

Comment 6

[Joe Walker [:jwalker]]

That last comment should read: "I got oranges locally with either this or bug 865252 in, so I backed them both out."

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: v1.1

Rebased to use |attachTestTabAndResume| since the alternative is no longer available.

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://tbpl.mozilla.org/?tree=Try&rev=aeb7060a682c

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/fa63467ea330

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fa63467ea330