Don't heavily prefer cache when loading source mapped sources

RESOLVED FIXED in Firefox 24

Status

defect
P2
normal
RESOLVED FIXED
6 years ago
Last year

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

(Blocks 1 bug)

unspecified
Firefox 24
x86
macOS
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

We pretty much always get the source as it was first loaded, because even hard refreshing doesn't actually check if the original source is modified or anything.
Posted patch wip (obsolete) — Splinter Review
Fixes the bug for me, but has no test yet.

* Using the LOAD_NORMAL flag didn't fix it for me, it had to be LOAD_BYPASS_CACHE.

* Good to pass the SourceActor the whole source map, because it will need it for bug 852792 anyways
Assignee: nobody → nfitzgerald
Posted patch v1 (obsolete) — Splinter Review
Rebased on top of my patch for bug 852792

Added test to ensure that if the file changes, we don't get the old version from the cache.
Attachment #741348 - Attachment is obsolete: true
Attachment #746680 - Flags: review?(past)
Posted patch v2 (obsolete) — Splinter Review
Woops, added the allowNonExistant parameter so that the console warning message won't happen and cause the tests to fail.

https://tbpl.mozilla.org/?tree=Try&rev=2d923b6182fd
Attachment #746680 - Attachment is obsolete: true
Attachment #746680 - Flags: review?(past)
Attachment #747021 - Flags: review?(past)
Comment on attachment 747021 [details] [diff] [review]
v2

Forgot that Panos is out for the week...
Attachment #747021 - Flags: review?(past) → review?(rcampbell)
Depends on: 852792
Comment on attachment 747021 [details] [diff] [review]
v2

Review of attachment 747021 [details] [diff] [review]:
-----------------------------------------------------------------

sensible
Attachment #747021 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team]
https://tbpl.mozilla.org/?tree=Fx-Team&rev=4dbd432e7667
https://hg.mozilla.org/integration/fx-team/rev/752dca088d71

Although: "CLOSED. BuiltBot issues: jobs don't seem to be showing up; tbpl fails to finish loading; retriggers not working;."
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Backed out for xpcshell bustage
https://hg.mozilla.org/integration/fx-team/rev/81fe6ab72d45

https://tbpl.mozilla.org/php/getParsedLog.php?id=22857908&tree=Fx-Team

I got oranged locally with either this or bug 865252 in, so I backed them both out.
Whiteboard: [fixed-in-fx-team]
That last comment should read: "I got oranges locally with either this or bug 852792 in, so I backed them both out."
Posted patch v2.1Splinter Review
Rebased to use |attachTestTabAndResume| since the alternative no longer exists.
Attachment #747021 - Attachment is obsolete: true
Whiteboard: [land-in-fx-team]
Status: NEW → ASSIGNED
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/0c312bf9446a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.