852996 - MarkupView leaks the whole Inspector after being closed

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Attachment: make sure to remove the load listener attached to the root node

STR:

1) Open a tab
2) Right-click to inspect some element on that new page
3) Close the Inspector

The devtools iframe with the MarkupView is now kept alive until we close the tab from [1].

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 727240 [details] [diff] [review]
make sure to remove the load listener attached to the root node

Review of attachment 727240 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but dcamp is the author of this code, so he will be a better reviewer.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 727240 [details] [diff] [review]
make sure to remove the load listener attached to the root node

What. The. Heck. This leaks permanently.

https://tbpl.mozilla.org/?tree=Try&rev=7f1cc5d065b7

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

It would be great if someone from the DevTools team could pick this up. I thought I had a quick patch for it... :)

Comment 4

[Joe Walker [:jwalker]]

Thanks Tim. We'll work on it.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I can't reproduce this, is it still an issue for you?

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Rebased. The patch already received an r+ from dcamp.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=39693258b124

Comment 7

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/953dcc5e5798

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/953dcc5e5798