Closed
Bug 853246
Opened 11 years ago
Closed 11 years ago
Optimize Panner and Listener methods when processing them would not have a significant effect
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
10.26 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #727445 -
Flags: review?(roc)
Comment on attachment 727445 [details] [diff] [review] Patch (v1) Review of attachment 727445 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/webaudio/WebAudioUtils.h @@ +18,5 @@ > + { > + using namespace std; > + return fabsf(v1 - v2) < 1e-7f; > + } > + static bool IsSameFloatingPointValue(double v1, double v2) Call these methods FuzzyEqual (that's what we call them elsewhere).
Attachment #727445 -
Flags: review?(roc) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/df7a8ab4ffed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df7a8ab4ffed
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
|
Assignee | |
Comment 4•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•