Optimize Panner and Listener methods when processing them would not have a significant effect

RESOLVED FIXED in mozilla22

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla22
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
Posted patch Patch (v1)Splinter Review
No description provided.
Attachment #727445 - Flags: review?(roc)
Comment on attachment 727445 [details] [diff] [review]
Patch (v1)

Review of attachment 727445 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/WebAudioUtils.h
@@ +18,5 @@
> +  {
> +    using namespace std;
> +    return fabsf(v1 - v2) < 1e-7f;
> +  }
> +  static bool IsSameFloatingPointValue(double v1, double v2)

Call these methods FuzzyEqual (that's what we call them elsewhere).
Attachment #727445 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/df7a8ab4ffed
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Assignee

Comment 4

6 years ago
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.