853414 - Themes installed in PB mode should not be visible in Normal Mode

Status: UNCONFIRMED

(Firefox :: Theme, enhancement)

Description

[Cornel Ionce [:noni]]

Steps to reproduce:
1. Enable Permanent Private Browsing.
2. Install a firefox theme.
3. Exit private browsing.
4. Start firefox in normal mode.

Expected result:
The theme installed in PB is not shown.

Actual result:
The theme installed in Private Browsing is shown in normal mode (the theme is not shown in PB mode).

Note:
If a theme is used before entering private browsing, it will be replaced with the one installed while using PB mode.


User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID:20130320062118

Comment 1

[(no longer active)]

Why?  Themes do not reveal information about your browsing session, so I don't think there is any reason to restrict them to private windows if they're installed in one.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> Why?  Themes do not reveal information about your browsing session, so I
> don't think there is any reason to restrict them to private windows if
> they're installed in one.

Is it in the realm of possibility that someone might want to have a different theme on their PB sessions but return to their normal browsing without carrying over anything (including theme mods)?  This sounds like it could be an enhancement request.

Comment 3

[(no longer active)]

(In reply to comment #2)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> > Why?  Themes do not reveal information about your browsing session, so I
> > don't think there is any reason to restrict them to private windows if
> > they're installed in one.
> 
> Is it in the realm of possibility that someone might want to have a different
> theme on their PB sessions but return to their normal browsing without carrying
> over anything (including theme mods)?  This sounds like it could be an
> enhancement request.

I think that's outside of the scope of PB.  Custom themes can change the appearance of private and custom windows, but that's not something that we want to support in the core product.

Comment 4

[u279076]

I think I agree that this is beyond the scope of what private browsing should support. I suspect this should be WONTFIX but I'm bumping it down to UNCONFIRMED in case someone can provide a convincing case why this should be in the core product.

Comment 5

[Ioana (away)]

I do agree with this not being in the scope of PB, but I still see a problem here: since the theme is not also applied while in PB mode, I would expect to at least get a warning message about it being applied to the regular session and only to it.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Ioana Budnar [QA] from comment #5)
> I do agree with this not being in the scope of PB, but I still see a problem
> here: since the theme is not also applied while in PB mode,

Lightweight themes being disabled in permanent PB mode was bug 852295.