853468 - Add graphics vendors and graphics devices/chips/cards to Signature Summary

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

We are collecting the "Adapter Vendor ID" and "Adapter Device ID" fields for crash reports, and we often have crashes that are only on products of some of those graphics vendors or some of their products.

We should add a list of those to the Signature Summary of crash signatures.

I wonder if it would be better to have two lists there, one for vendor, one for devices/chips/cards (whatever we call them there), or one list that combines them.

What we'll probably need is tables backing the display that translate those IDs to names of the vendors and devices, and we'll want some way for editing, at least adding entries there so that gathering and adding data there isn't all on the Socorro team. Still, where we don't have entries in those translation tables, we'll want to display the pure ID. Maybe we could always display the ID and only add the name where we know one.


As a note, if we use "graphics device" here, then we should use something like "mobile device" in bug 853452.

Comment 1

[Brandon Savage [:brandon]]

We need more direction on what you're looking for in this bug. Please spec this bug more fully with exactly what you want.

The ability to edit with an admin section is kind of out of scope for the signature summary. Additionally, how are we translating the data on the devices/chips/cards from raw data into something useable? Is this coming in identified by the reporter or do we have to interface with a data source to get this information.

Let's discuss this further this week during the workweek.

Comment 2

[Brandon Savage [:brandon]]

Per KiaRo, here's the details of this bug:

* Need an admin UI that allows us to correlate vendor and adapter hex IDs together. 

-------------------------------------------------------------
| id | vendor_hex | adapter_hex | vendor_name | adapter_name|

* A signature summary that contains vendor id, adapter id, percentage of crashes. Show hex for those we can't decode, show decoded values from map table when we have available values.

Note, we will want to be able to decode vendor name only when the chipset data is unavailable; however, normalization is unnecessary here since we can do a UNIQUE vendor_hex to get a vendor name in a secondary search.

Comment 3

[Brandon Savage [:brandon]]

Note that to complete this bug, we only need the signature summary. I will file a follow on bug that will address the admin UI.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/63d6b9d83161740767f17626f70893786c4e69f1
Fixes Bug 853468 - Creates a materialized view and stored procedures for graphics adapters, and adds this report to signature summary.

https://github.com/mozilla/socorro/commit/9bfb178caa8fc175196d2e1018d66e6487c29603
Merge pull request #1494 from brandonsavage/bug853468graphicsdevices

 Fixes Bug 853468 - Creates a materialized view and stored procedures for graphics adapters, and adds this report to signature summary.

Comment 5

[Brandon Savage [:brandon]]

Steps to test:

Verify for crashes that there is in fact a new report for graphics adapters, and that for most of them it contains some kind of data. The numbers should also make sense and there should be no duplicates.

Comment 6

[Matt Brandt [:mbrandt]]

Reopening and adding a blocking bug 916628 - data for this report isn't available (yet)

11:30 brandonsavage: lonnen: selenamarie: did the stage crontabber ever complete or does it keep failing on graphics_device?
11:30 lonnen: brandonsavage: still failing to my knowledge

Comment 7

[Brandon Savage [:brandon]]

Data now available on stage.

Comment 8

[Matt Brandt [:mbrandt]]

QA is holding off on verification until blocking bug 916628 is resolved.

Comment 9

[Matt Brandt [:mbrandt]]

QA verified on stage - nicely done. Graphics section is present and with data.

https://crash-stats.allizom.org/report/list?signature=js%3A%3Amjit%3A%3Astubs%3A%3APos%28js%3A%3AVMFrame%26%29