853642 - provider menu organization/cleanup

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

The provider menu's are currently structured like this:

----
user profile
----
show sidebar
show notifications
----
o provider 1
o provider 2
x provider 3 (current provider)
----
turn on/off current provider
manage services...

From the ux review Boriss and i did, it makes sense to group the provider specific items together, so it would look like:

----
user profile
----
show sidebar
show notifications
turn on/off current provider
----
o provider 1
o provider 2
x provider 3
----
manage services...

Additionally, clicking on the current provider in the list of providers would also turn off the provider, emulating an unchecking of that provider.

Comment 1

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> Additionally, clicking on the current provider in the list of providers
> would also turn off the provider, emulating an unchecking of that provider.

via irc we decided against changing that for now.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: turnoff.png

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: turnon.png

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: move menu

I almost feel silly asking for review on this.  quick and simple.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: bug-empty menu name.png

since I have to also touch this menu, I'm fixing the bug shown in this menu at the same time.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: move menu, fix missing menu label

Comment 7

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b65289e2b06c

Comment 8

[Matt Brubeck (:mbrubeck)]

Sorry, I had to back this out because of failures in multiple mochitests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/109739e76662

Comment 9

[Shane Caraveo (:mixedpuppy)]

Attachment: move menu, fix missing menu label

fixed patch, sent to try for a quick verification on one platform.  carrying forward r+

https://tbpl.mozilla.org/?tree=Try&rev=fa5a16b322f7

Comment 10

[Shane Caraveo (:mixedpuppy)]

fixed patch pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/a450ba2ae0a1

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a450ba2ae0a1

Comment 12

[u279076]

Verified fixed in Firefox 22.0b5.