Closed Bug 853642 Opened 8 years ago Closed 8 years ago

provider menu organization/cleanup

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 22

People

(Reporter: mixedpuppy, Assigned: scaraveo)

Details

(Keywords: uiwanted)

Attachments

(4 files, 2 obsolete files)

The provider menu's are currently structured like this:

----
user profile
----
show sidebar
show notifications
----
o provider 1
o provider 2
x provider 3 (current provider)
----
turn on/off current provider
manage services...

From the ux review Boriss and i did, it makes sense to group the provider specific items together, so it would look like:

----
user profile
----
show sidebar
show notifications
turn on/off current provider
----
o provider 1
o provider 2
x provider 3
----
manage services...

Additionally, clicking on the current provider in the list of providers would also turn off the provider, emulating an unchecking of that provider.
Keywords: uiwanted
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> Additionally, clicking on the current provider in the list of providers
> would also turn off the provider, emulating an unchecking of that provider.

via irc we decided against changing that for now.
Attached image turnoff.png
Attached image turnon.png
Attached patch move menu (obsolete) — Splinter Review
I almost feel silly asking for review on this.  quick and simple.
Attachment #727913 - Flags: review?(mhammond)
Attachment #727910 - Flags: ui-review?(jboriss)
Attachment #727910 - Flags: ui-review?(jboriss) → ui-review+
Attached image bug-empty menu name.png
since I have to also touch this menu, I'm fixing the bug shown in this menu at the same time.
Attachment #727913 - Attachment is obsolete: true
Attachment #727913 - Flags: review?(mhammond)
Attachment #727922 - Flags: review?(mhammond)
Attachment #727922 - Flags: review?(mhammond) → review+
Sorry, I had to back this out because of failures in multiple mochitests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/109739e76662
fixed patch, sent to try for a quick verification on one platform.  carrying forward r+

https://tbpl.mozilla.org/?tree=Try&rev=fa5a16b322f7
Attachment #727922 - Attachment is obsolete: true
Attachment #728515 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a450ba2ae0a1
Assignee: nobody → scaraveo
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Verified fixed in Firefox 22.0b5.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.