Closed
Bug 853642
Opened 13 years ago
Closed 13 years ago
provider menu organization/cleanup
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 22
People
(Reporter: mixedpuppy, Assigned: scaraveo)
Details
(Keywords: uiwanted)
Attachments
(4 files, 2 obsolete files)
|
59.18 KB,
image/png
|
jboriss
:
ui-review+
|
Details |
|
21.57 KB,
image/png
|
Details | |
|
29.32 KB,
image/png
|
Details | |
|
3.92 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
turnoff.png
The provider menu's are currently structured like this:
----
user profile
----
show sidebar
show notifications
----
o provider 1
o provider 2
x provider 3 (current provider)
----
turn on/off current provider
manage services...
From the ux review Boriss and i did, it makes sense to group the provider specific items together, so it would look like:
----
user profile
----
show sidebar
show notifications
turn on/off current provider
----
o provider 1
o provider 2
x provider 3
----
manage services...
Additionally, clicking on the current provider in the list of providers would also turn off the provider, emulating an unchecking of that provider.
|
Reporter | |
Comment 1•13 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> Additionally, clicking on the current provider in the list of providers
> would also turn off the provider, emulating an unchecking of that provider.
via irc we decided against changing that for now.
|
|
Reporter | |
Comment 2•13 years ago
|
||
|
|
Reporter | |
Comment 3•13 years ago
|
||
|
|
Reporter | |
Comment 4•13 years ago
|
||
I almost feel silly asking for review on this. quick and simple.
Attachment #727913 -
Flags: review?(mhammond)
|
|
Reporter | |
Updated•13 years ago
|
Attachment #727910 -
Flags: ui-review?(jboriss)
|
||
Updated•13 years ago
|
Attachment #727910 -
Flags: ui-review?(jboriss) → ui-review+
|
|
Reporter | |
Comment 5•13 years ago
|
||
since I have to also touch this menu, I'm fixing the bug shown in this menu at the same time.
|
|
Reporter | |
Comment 6•13 years ago
|
||
Attachment #727913 -
Attachment is obsolete: true
Attachment #727913 -
Flags: review?(mhammond)
Attachment #727922 -
Flags: review?(mhammond)
|
||
Updated•13 years ago
|
Attachment #727922 -
Flags: review?(mhammond) → review+
|
|
Reporter | |
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
Sorry, I had to back this out because of failures in multiple mochitests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/109739e76662
|
|
Reporter | |
Comment 9•13 years ago
|
||
fixed patch, sent to try for a quick verification on one platform. carrying forward r+
https://tbpl.mozilla.org/?tree=Try&rev=fa5a16b322f7
Attachment #727922 -
Attachment is obsolete: true
Attachment #728515 -
Flags: review+
|
|
Reporter | |
Comment 10•13 years ago
|
||
fixed patch pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/a450ba2ae0a1
|
||
Comment 11•13 years ago
|
||
Assignee: nobody → scaraveo
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•