provider menu organization/cleanup

VERIFIED FIXED in Firefox 22

Status

()

Firefox
SocialAPI
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mixedpuppy, Assigned: scaraveo)

Tracking

({uiwanted})

unspecified
Firefox 22
x86
Mac OS X
uiwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
The provider menu's are currently structured like this:

----
user profile
----
show sidebar
show notifications
----
o provider 1
o provider 2
x provider 3 (current provider)
----
turn on/off current provider
manage services...

From the ux review Boriss and i did, it makes sense to group the provider specific items together, so it would look like:

----
user profile
----
show sidebar
show notifications
turn on/off current provider
----
o provider 1
o provider 2
x provider 3
----
manage services...

Additionally, clicking on the current provider in the list of providers would also turn off the provider, emulating an unchecking of that provider.
(Reporter)

Updated

4 years ago
Keywords: uiwanted
(Reporter)

Comment 1

4 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> Additionally, clicking on the current provider in the list of providers
> would also turn off the provider, emulating an unchecking of that provider.

via irc we decided against changing that for now.
(Reporter)

Comment 2

4 years ago
Created attachment 727910 [details]
turnoff.png
(Reporter)

Comment 3

4 years ago
Created attachment 727911 [details]
turnon.png
(Reporter)

Comment 4

4 years ago
Created attachment 727913 [details] [diff] [review]
move menu

I almost feel silly asking for review on this.  quick and simple.
Attachment #727913 - Flags: review?(mhammond)
(Reporter)

Updated

4 years ago
Attachment #727910 - Flags: ui-review?(jboriss)
Attachment #727910 - Flags: ui-review?(jboriss) → ui-review+
(Reporter)

Comment 5

4 years ago
Created attachment 727919 [details]
bug-empty menu name.png

since I have to also touch this menu, I'm fixing the bug shown in this menu at the same time.
(Reporter)

Comment 6

4 years ago
Created attachment 727922 [details] [diff] [review]
move menu, fix missing menu label
Attachment #727913 - Attachment is obsolete: true
Attachment #727913 - Flags: review?(mhammond)
Attachment #727922 - Flags: review?(mhammond)

Updated

4 years ago
Attachment #727922 - Flags: review?(mhammond) → review+
(Reporter)

Comment 7

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b65289e2b06c
Sorry, I had to back this out because of failures in multiple mochitests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/109739e76662
(Reporter)

Comment 9

4 years ago
Created attachment 728515 [details] [diff] [review]
move menu, fix missing menu label

fixed patch, sent to try for a quick verification on one platform.  carrying forward r+

https://tbpl.mozilla.org/?tree=Try&rev=fa5a16b322f7
Attachment #727922 - Attachment is obsolete: true
Attachment #728515 - Flags: review+
(Reporter)

Comment 10

4 years ago
fixed patch pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/a450ba2ae0a1
https://hg.mozilla.org/mozilla-central/rev/a450ba2ae0a1
Assignee: nobody → scaraveo
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Verified fixed in Firefox 22.0b5.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.