Closed Bug 853752 Opened 7 years ago Closed 7 years ago

B2G MMS: after retrieving MMS, delete the thread containing the previous notification indication

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23
blocking-b2g leo+
Tracking Status
firefox21 --- wontfix
firefox22 --- wontfix
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

Attachments

(2 files, 7 obsolete files)

When receiving an MMS, we expect to receive 2 types of notification indications. The first one is asking users to retrieve MMS. The second one is the retrieved MMS with the real content and receivers.

For now, we're treating these 2 notification indication as 2 different DB records. However, we shouldn't do that because they should belong to different threads. A user scenario could be: one thread collects the "download request" messages and the other collects the real MMS message involved with the receivers.

See bug 845643 for the previous implementation.
After some off-line discussions, we decide to change our goal for this issue to: after retrieving MMS (that is, a retrieval confirmation is received), we should delete the thread containing the previous notification indication, if the thread doesn't contain any messages anymore.
Summary: B2G MMS: shouldn't treat the two notification indications as different DB records when receiving MMS → B2G MMS: after retrieving MMS, delete the thread containing the previous notification indication
Attached patch Patch v1.1 (obsolete) — Splinter Review
Attachment #736729 - Attachment is obsolete: true
Assignee: nobody → ctai
Status: NEW → ASSIGNED
Assignee: ctai → gene.lian
Gene want to take this bug. Change to him.
This should also be marked as leo+, because we should delete the notification thread after the MMS is received. Otherwise, we'll have redundant threads referring to the same MMS.
blocking-b2g: --- → leo?
Whiteboard: [NO_UPLIFT]
Attached patch Patch, V2 (obsolete) — Splinter Review
Attachment #736730 - Attachment is obsolete: true
Attachment #738441 - Flags: review?(vyang)
Attachment #738441 - Flags: review?(ctai)
Blocks: 840055
This looks like a leo+ to me.
blocking-b2g: leo? → leo+
Attached patch Patch, V3 (obsolete) — Splinter Review
Attachment #738441 - Attachment is obsolete: true
Attachment #738441 - Flags: review?(vyang)
Attachment #738441 - Flags: review?(ctai)
Attachment #739009 - Flags: review?(vyang)
Attachment #739009 - Flags: review?(vyang)
Attached patch Patch, V4 (obsolete) — Splinter Review
Attachment #739009 - Attachment is obsolete: true
Attachment #739009 - Flags: review?(vyang)
Attachment #739045 - Flags: review?(vyang)
Attached patch Patch, V4.1 (obsolete) — Splinter Review
Attachment #739045 - Attachment is obsolete: true
Attachment #739045 - Flags: review?(vyang)
Attachment #739097 - Flags: review?(vyang)
Attachment #739097 - Flags: review?(vyang) → review+
I'll land this after some testings.
Attached patch gene-test (obsolete) — Splinter Review
Attached patch Patch, V4.2Splinter Review
Attachment #739097 - Attachment is obsolete: true
Attachment #739451 - Attachment is obsolete: true
Attachment #739585 - Flags: review+
Since the Madrid work week is finished, I'm not very sure we should land this patch to inbound or birch. Ask for checkin-needed. Try server looks fine.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cf284804c348
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
https://hg.mozilla.org/releases/mozilla-b2g18/rev/dcdc2b74cff1

Per the conclusion during the work week in Madrid, we were in agreement we could land the MMS patches to the b2g18 branch. This patch doesn't touch the RIL interface change so it should be pretty safe to land.
Depends on: 865621
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Patch, follow upSplinter Review
Attachment #741791 - Flags: review?(vyang)
Attachment #741791 - Flags: review?(vyang) → review+
https://hg.mozilla.org/mozilla-central/rev/0e8b99f4d0b3
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Blocks: 865992
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.