853831 - Reader mode toolbar doesn't appear at the top of the page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Peter Retzer (:pretzer)]

The reader mode toolbar cannot be invoked when the page is scrolled to the top. After scrolling down a bit the toolbar can be easily invoked by tapping somewhere on the page.
This also means that toolbar doesn't appear automatically when switching into reader mode, because - obviously - the page is scrolled to the top after page load. :-)

Switching 'browser.chrome.dynamictoolbar' to false fixes the problem and restores the old behavior, so this is likely a regression from bug 716403.

Comment 1

[Chris Lord [:cwiiis]]

Ah, this will be because it's fixed to the bottom of the page - I think I had this fixed in an earlier build and lost track, reasonably easy fix, will sort it out.

I'll try to get this done today but otherwise this may have to wait a little.

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Fix viewport margins during overscroll on the opposite side of the axis

This fixes the problem in reader mode, and on other sites with similar setups.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 728223 [details] [diff] [review]
Fix viewport margins during overscroll on the opposite side of the axis

Review of attachment 728223 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/gfx/GeckoLayerClient.java
@@ +59,5 @@
>      private DrawListener mDrawListener;
>  
>      /* Used as a temporary ViewTransform by syncViewportInfo */
>      private final ViewTransform mCurrentViewTransform;
> +    private final RectF mCurrentViewTransformMargins;

Update the comment above mCurrentViewTransform to include this new field as well.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Try build in progress at https://tbpl.mozilla.org/?tree=Try&rev=6c7970a9e405

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d91a87b222e4

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d91a87b222e4

Comment 8

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-03-27)
-device: LG Nexus 4
-OS: Android 4.2.2