853896 - Turn off MOZ_EVENT_TRACE when profiling

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 728260 [details] [diff] [review]
patch

Review of attachment 728260 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/EventTracer.cpp
@@ +182,5 @@
>    if (!InitWidgetTracing())
>      return false;
>  
> +  TracerStartClosure* args = new TracerStartClosure();
> +  args->mLogTracing = aLog;

Comment here that the tracer thread owns the object and will delete it.

::: toolkit/xre/EventTracer.h
@@ +9,5 @@
>  
>  // Create a thread that will fire events back at the
>  // main thread to measure responsiveness. Return true
>  // if the thread was created successfully.
> +bool InitEventTracing(bool aLog);

Update the comment here to mention the argument.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch r=ted

https://hg.mozilla.org/integration/mozilla-inbound/rev/43e3534fcf86

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43e3534fcf86