854182 - Caret monocle doesn't position properly after ContentAreaObserver adjusts content dims

Status: RESOLVED INVALID

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

STR:

1) tap a form input to bring up the caret and the keyboard

result: when the soft keyboard comes up the caret is not adjusted to reflect the new position of the form.

also, in some cases the form input will be pushed off screen, so we have to be careful about when we display monocles.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

details:

1) move ContentAreaObserver into its own file
2) fire an new event ('ViewableSizeChanging') right before we change the viewable area
3) hide monocles on 'ViewableSizeChanging'
4) trigger a recalculation of the monocle position after 'ViewableSizeChanged' fires, which also shows the monocles again.
5) track the current selection mode in SelectionHandler so we can reuse "Browser:SelectionUpdate" for this.

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 728757 [details] [diff] [review]
patch

Review of attachment 728757 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/helperui/SelectionHelperUI.js
@@ +856,5 @@
>  
> +  // triggered when the viable size changes due to keyboard display
> +  _onViewableSizeChanging: function _onViewableSizeChanging() {
> +    if (this._startMark) {
> +      this.startMark.visible = false;

I don't think visible has a setter. I think the proper way to do this is:
this.startMark.hide();

@@ +859,5 @@
> +    if (this._startMark) {
> +      this.startMark.visible = false;
> +    }
> +    if (this._endMark) {
> +      this.endMark.visible = false;

I think this should be this.endMark.hide();

@@ +862,5 @@
> +    if (this._endMark) {
> +      this.endMark.visible = false;
> +    }
> +    if (this._caretMark) {
> +      this.caretMark.visible = false;

I think this should be this.caretMark.hide();

Comment 3

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #2)
> 
> I don't think visible has a setter. I think the proper way to do this is:
> this.startMark.hide();

doh, nice catch.

Comment 4

[Jim Mathies [:jimm]]

I'm going to delay this until we have a chance to look at the content area changes we make when he keyboard is displayed.

There are a couple problems here - 

1) content doesn't always reposition for some reason. I can reproduce repositioning on some sites but not others.
2) ViewableSizeChanged doesn't always coincide with reflow / paint.