854469 - Sliders are visually messed up when native <input type=range> is enabled

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jonathan Watt [:jwatt]]

Even with the fix for bug 854138, the sliders in the Firefox OS Sound and Display settings screens are messed up if the native <input type=range> support is enabled. (This native support is enabled by default in Mozilla v22.)

There are various styling issues that I've been discussing with people via email, but it's probably time to take that discussion to a bug or two.

The sliders I'm talking about here are:

http://telefonicaid.github.com/Gaia-UI-Building-Blocks/index.html#widgets/seekbars/

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

I tested this with a master build on a Unagi device, against 1.0.1 on another Unagi device. The rendering of the sliders in the Sound and Display settings screen are virtually identical between the two. The master build is using <input type=range>, the 1.0.1 build is using the <div> and <span> polyfill.

Comment 3

[Jonathan Watt [:jwatt]]

The utils.js changes to add the without_bug344618_polyfill class are not necessary, but I thought it prudent in order to have a visual cue in the markup that would show up in the debugger in case anyone that is unaware of these changes ends up debugging the sliders at some point.

Comment 4

[Jonathan Watt [:jwatt]]

PR: https://github.com/mozilla-b2g/gaia/pull/9013

Comment 5

[Fabien Cazenave [:kaze]]

Comment on attachment 733870 [details] [diff] [review]
patch

https://github.com/mozilla-b2g/gaia/commit/7bc54c21c61c2b04c62ed2db061316e68ab2a8a4

Nit: I had to fix two linter issues. Next time, please check your patch with gjslint if you can.

Comment 6

[Fabien Cazenave [:kaze]]

Tested with b2g18 and trunk.

Comment 7

[Jonathan Watt [:jwatt]]

(In reply to Fabien Cazenave [:kaze] from comment #5)
> Nit: I had to fix two linter issues. Next time, please check your patch with
> gjslint if you can.

Will do, thanks, kaze!

Comment 8

[Wayne Chang [:wchang]]

Does this fix any HD branch-specific issue? 
If not we wont take it for now as HD should align as much as possible with v1-train leo unless it is HD layout/asset specific.

Please renom HD? if this is the case (makes HD look broken), otherwise we'll leave it on master for future releases.

Comment 9

[Eric Pang [:epang] UX]

(In reply to Wayne Chang [:wchang] from comment #8)
> Does this fix any HD branch-specific issue? 
> If not we wont take it for now as HD should align as much as possible with
> v1-train leo unless it is HD layout/asset specific.
> 
> Please renom HD? if this is the case (makes HD look broken), otherwise we'll
> leave it on master for future releases.

Sam, you mentioned Pavel needed this bug to land for an HD bug?  Can you let me know if this bug affects HD as well? Thanks!

Comment 10

[Sam Joch [:samjoch]]

Attachment: How v1.1.0hd is affected

Comment 11

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #10)
> Created attachment 793886 [details]
> How v1.1.0hd is affected

Thanks Sam! Wayne, I've renomed fot HD, see the screen Sam added. Thanks!

Comment 12

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #11)
> (In reply to Sam Joch [:samjoch] from comment #10)
> > Created attachment 793886 [details]
> > How v1.1.0hd is affected
> 
> Thanks Sam! Wayne, I've renomed fot HD, see the screen Sam added. Thanks!

Hey Sam, Wayne has made this HD+ so we can land in HD now. Thanks!

Comment 13

[Sam Joch [:samjoch]]

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/2c5b7f4333750819372b2adf0f35a7a7f4e1cb30

Still need https://bugzilla.mozilla.org/show_bug.cgi?id=854138 and https://bugzilla.mozilla.org/show_bug.cgi?id=802234 to complete fix of input in v1.1.0hd.

Comment 14

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0