Closed Bug 854138 Opened 12 years ago Closed 12 years ago

Fix blank Sound and Display settings screens (JavaScript error: app://settings.gaiamobile.org/js/settings.js, line 294: ranges[i].refresh is not a function)

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.1hd fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.1hd --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

The Sound and Display settings screens in B2G builds that are built against mozilla-central are broken (blank) and render the phone unusable until rebooted if the user tries to view them. The console contains this error: JavaScript error: app://settings.gaiamobile.org/js/settings.js, line 294: ranges[i].refresh is not a function The issue is that the polyfill code for <input type=range> adds a refresh() method to the element that replaces the <input>, and some code calls that without checking if the element is a native implementation or the polyfill. The pref to enable native <input type=range> was flipped on in bug 841948.
Attached patch patchSplinter Review
Attachment #728661 - Flags: review?(mwu)
I'm making the code work in the case where the native <input type=range> is both enabled and disabled (rather than removing the polyfill) since the gaia code has to work with both older and newer gecko trees for now.
Comment on attachment 728661 [details] [diff] [review] patch Forwarding review to someone who might know the code.
Attachment #728661 - Flags: review?(mwu) → review?(kaze)
Attachment #728661 - Flags: review?(kaze) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 853808
Need this one for v1.1.0hd (related to https://bugzilla.mozilla.org/show_bug.cgi?id=854469)
Blocks: 802234
Flags: needinfo?(wchang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: