Closed Bug 854835 Opened 9 years ago Closed 9 years ago

Intermittent test_bug472986.html,test_bug544462.html,test_unsecurePictureDup.html,test_removal_ondecode.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)]

Categories

(Core :: Graphics: ImageLib, defect)

x86
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: emorley, Assigned: seth)

References

Details

(Keywords: crash, intermittent-failure)

Crash Data

Attachments

(1 obsolete file)

Rev3 WINNT 6.1 mozilla-inbound debug test mochitest-5 on 2013-03-25 19:11:48 PDT for push 1555815d144a

slave: talos-r3-w7-072

https://tbpl.mozilla.org/php/getParsedLog.php?id=21084792&tree=Mozilla-Inbound

{
19:25:49     INFO -  163641 INFO TEST-START | /tests/security/ssl/mixedcontent/test_bug472986.html
19:25:49     INFO -  ++DOMWINDOW == 72 (16C48BE0) [serial = 2817] [outer = 077F9DC8]
19:25:50     INFO -  --DOMWINDOW == 71 (16C4F358) [serial = 2811] [outer = 16C4A658] [url = about:blank]
19:25:50     INFO -  --DOCSHELL 1A6BA168 == 8 [id = 215]
19:25:50     INFO -  --DOCSHELL 149AC248 == 7 [id = 213]
19:25:50     INFO -  --DOMWINDOW == 70 (1261C330) [serial = 2797] [outer = 00000000] [url = https://example.com/tests/security/ssl/mixedcontent/test_bug329869.html?runtest]
19:25:50     INFO -  --DOMWINDOW == 69 (1261E9B0) [serial = 2796] [outer = 00000000] [url = https://example.com/tests/security/ssl/mixedcontent/test_bug329869.html?runtest]
19:25:50     INFO -  --DOMWINDOW == 68 (1261D1A0) [serial = 2795] [outer = 00000000] [url = about:blank]
19:25:50     INFO -  --DOMWINDOW == 67 (1261D670) [serial = 2802] [outer = 00000000] [url = about:blank]
19:25:51     INFO -  Assertion failure: NS_IsMainThread_P(), at e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/image/src/RasterImage.cpp:3603
19:25:54  WARNING -  TEST-UNEXPECTED-FAIL | /tests/security/ssl/mixedcontent/test_bug472986.html | Exited with code -2147483645 during test run
19:25:54     INFO -  INFO | automation.py | Application ran for: 0:10:06.056000
19:25:54     INFO -  INFO | automation.py | Reading PID log: c:\users\cltbld\appdata\local\temp\tmpln3nvupidlog
19:26:10     INFO -  PROCESS-CRASH | /tests/security/ssl/mixedcontent/test_bug472986.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)]
19:26:10     INFO -  Crash dump filename: c:\users\cltbld\appdata\local\temp\tmp50tyjb\minidumps\93b4f2b6-88af-4b89-8e7f-243daa13e5d3.dmp
19:26:10     INFO -  Operating system: Windows NT
19:26:10     INFO -                    6.1.7600
19:26:10     INFO -  CPU: x86
19:26:10     INFO -       GenuineIntel family 6 model 23 stepping 10
19:26:10     INFO -       2 CPUs
19:26:10     INFO -  Crash reason:  EXCEPTION_BREAKPOINT
19:26:10     INFO -  Crash address: 0x6a71fd71
19:26:10     INFO -  Thread 32 (crashed)
19:26:10     INFO -   0  xul.dll!mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *) [RasterImage.cpp:1555815d144a : 3603 + 0x38]
19:26:10     INFO -      eip = 0x6a71fd71   esp = 0x15bffbc4   ebp = 0x15bffbd4   ebx = 0x7707060c
19:26:10     INFO -      esi = 0x693f1440   edi = 0x7706509b   eax = 0x00000000   ecx = 0xe9515c04
19:26:10     INFO -      edx = 0x694ee4d8   efl = 0x00200212
19:26:10     INFO -      Found by: given as instruction pointer in context
19:26:10     INFO -   1  xul.dll!mozilla::image::RasterImage::DecodePool::DecodeJob::Run() [RasterImage.cpp:1555815d144a : 3728 + 0xd]
19:26:10     INFO -      eip = 0x6a720c24   esp = 0x15bffbdc   ebp = 0x15bffbfc
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   2  xul.dll!nsThreadPool::Run() [nsThreadPool.cpp:1555815d144a : 194 + 0xd]
19:26:10     INFO -      eip = 0x6bc7f870   esp = 0x15bffc04   ebp = 0x15bffc30
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   3  xul.dll!nsThread::ProcessNextEvent(bool,bool *) [nsThread.cpp:1555815d144a : 627 + 0xd]
19:26:10     INFO -      eip = 0x6bc7cd76   esp = 0x15bffc38   ebp = 0x15bffc88
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   4  xul.dll!NS_ProcessNextEvent_P(nsIThread *,bool) [nsThreadUtils.cpp:1555815d144a : 238 + 0xc]
19:26:10     INFO -      eip = 0x6bc21e96   esp = 0x15bffc90   ebp = 0x15bffc9c
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   5  xul.dll!nsThread::ThreadFunc(void *) [nsThread.cpp:1555815d144a : 265 + 0x7]
19:26:10     INFO -      eip = 0x6bc7c314   esp = 0x15bffca4   ebp = 0x15bffcc4
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   6  nss3.dll!_PR_NativeRunThread [pruthr.c:1555815d144a : 395 + 0x8]
19:26:10     INFO -      eip = 0x696dc49b   esp = 0x15bffccc   ebp = 0x15bffd24
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   7  nss3.dll!pr_root [w95thred.c:1555815d144a : 90 + 0xc]
19:26:10     INFO -      eip = 0x696e35ed   esp = 0x15bffce8   ebp = 0x15bffd24
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   8  MSVCR100D.dll + 0x4a292
19:26:10     INFO -      eip = 0x693da293   esp = 0x15bffcf0   ebp = 0x15bffd24
19:26:10     INFO -      Found by: call frame info
19:26:10     INFO -   9  MSVCR100D.dll + 0x4a223
}
Crash Signature: [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)] → [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage*)]
Depends on: 854762
https://tbpl.mozilla.org/php/getParsedLog.php?id=21121693&tree=Mozilla-Inbound
Summary: Intermittent ssl/mixedcontent/test_bug472986.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)] → Intermittent test_bug472986.html,test_bug544462.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)]
Yes, this might be the same (or the same cause) as bug 854762, which is a reproducible crasher with new code. Let's hope to see a fix soon.
https://tbpl.mozilla.org/php/getParsedLog.php?id=21239499&tree=Mozilla-Inbound
Summary: Intermittent test_bug472986.html,test_bug544462.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)] → Intermittent test_bug472986.html,test_bug544462.html,test_unsecurePictureDup.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)]
https://tbpl.mozilla.org/php/getParsedLog.php?id=21270801&tree=Mozilla-Inbound
Summary: Intermittent test_bug472986.html,test_bug544462.html,test_unsecurePictureDup.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)] → Intermittent test_bug472986.html,test_bug544462.html,test_unsecurePictureDup.html,test_removal_ondecode.html | application crashed [@ mozilla::image::RasterImage::DecodePool::RequestDecode(mozilla::image::RasterImage *)]
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #15)
> Yes, this might be the same (or the same cause) as bug 854762, which is a
> reproducible crasher with new code. Let's hope to see a fix soon.

Nah, I doubt these two are the same.

This is an assertion failing, and the assertion itself is blatantly incorrect.

This is so trivial that I'm not to bother to create a separate bug for this. Will have a patch up shortly.
No longer depends on: 854762
Here's the patch. It's untrue that DecodePool::RequestDecode is only called from the main thread, so we shouldn't assert that. DecodeJob::Run can also call it. Furthermore, I don't see any reason to think that it's unsafe as long as we hold the decoding mutex (which we do, and we assert so).
Attachment #732126 - Flags: review?(jmuizelaar)
Assignee: nobody → seth
Attachment #732126 - Flags: review?(jmuizelaar) → review+
Nothing's ever easy. This turned out to be more complex than it appeared. I'll create a new bug for this.
Depends on: 857367
Attachment #732126 - Attachment is obsolete: true
I'll fix this in bug 857367.
I believe that most recent star doesn't include the patch from bug 857367. Hopefully once things settle down a little we can confirm that this is now fixed. (Since it happened on Aurora we might want to consider uplifting bug 857367...)
(OrangeWFM bugs not touched for 2 months)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.