The default bug view has changed. See this FAQ.

Change - Remove Master Password Support

VERIFIED FIXED in Firefox 22

Status

Firefox for Metro
General
P1
normal
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: jimm, Assigned: rsilveira)

Tracking

Trunk
Firefox 22
x86_64
Windows 8.1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=change c=operations u=developer p=1)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
See bug 853391. We will not support this feature in metrofx.
Whiteboard: p=1

Updated

4 years ago
Blocks: 850809
Priority: -- → P1
QA Contact: jbecerra
Summary: Remove master password support → Change - Remove Master Password Support
Whiteboard: p=1 → feature=change c=operations u=developer p=1
(Assignee)

Updated

4 years ago
Assignee: nobody → rsilveira
Created attachment 729901 [details] [diff] [review]
Patch v1

I kept browser\metro\base\content\preferences.js because it's used by the patch for bug 845484. Once that one lands I can update this patch.
Attachment #729901 - Flags: review?(mbrubeck)
Attachment #729901 - Flags: review?(mbrubeck) → review+
(Assignee)

Updated

4 years ago
Attachment #729901 - Flags: checkin?
Attachment #729901 - Flags: checkin? → checkin?(mbrubeck)
Comment on attachment 729901 [details] [diff] [review]
Patch v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c4bad14048d
Attachment #729901 - Flags: checkin?(mbrubeck) → checkin+

Updated

4 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/5c4bad14048d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22

Updated

4 years ago
Flags: needinfo?(jbecerra)
Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130404 Firefox/23.0

No Master Password in Options. Visiting and logging in to a site which requires authentication saved the password without problems.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Ensured that "Master Password" is not present under "Options" in the "Setting" charm
- Ensured that a "Remember Password" prompt appears at the top of the browser when logging into a website with a password
- Ensured that selecting "Remember Password" saves the passwords and can be used to re-login without issues (tried several different sites)
- Ensured that you can "Change" the password if you inserted an incorrect password previously
- Ensured that selecting "Clear" under "Options" removes all of the saved passwords
Went through the following "Change" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-14-03-11-00-mozilla-central/

- Went through the test cases added in comment 5 without any issues
- Ensured that selecting "Not for this site" will not ask the user to remember the password again for that particular site
- Ensured that the "Remember Password" is not dismissed until a user makes a selection

Found Bug 883484 when going through the following "Change" but found a better "Story" to block.

Comment 7

4 years ago
This does not have a story to attach to since it's a removal of a feature that was never captured in a Metro story.
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment5 and 6 got expected result.

Comment 9

4 years ago
FWIW in the current Metro build, when I forced a sync with my account which has a master account set up IN ADDITION to other security measures I have in place and all my passwords were brought in but no master password is ever needed within Metro.

I think it's a really bad idea to not allow a user to encrypt passwords at the Metro Firefox level via the existing sync system especially considering the recent press regarding Chrome's lack of a master password issue.

Comment 10

4 years ago
(In reply to aasymonds from comment #9)
> FWIW in the current Metro build, when I forced a sync with my account which
> has a master account set up IN ADDITION to other security measures I have in
> place and all my passwords were brought in but no master password is ever
> needed within Metro.
> 
> I think it's a really bad idea to not allow a user to encrypt passwords at
> the Metro Firefox level via the existing sync system especially considering
> the recent press regarding Chrome's lack of a master password issue.

Thank you for your input, aasymonds. For future reference, advocacy comments are not appropriate for Bugzilla.  You can learn more about how we use Bugzilla here https://bugzilla.mozilla.org/page.cgi?id=etiquette.html
Depends on: 949333
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.