Last Comment Bug 854881 - Change - Remove Master Password Support
: Change - Remove Master Password Support
Status: VERIFIED FIXED
feature=change c=operations u=develop...
:
Product: Firefox for Metro
Classification: Client Software
Component: General (show other bugs)
: Trunk
: x86_64 Windows 8.1
: P1 normal (vote)
: Firefox 22
Assigned To: Rodrigo Silveira [:rsilveira] [:rodms]
: juan becerra [:juanb]
:
Mentors:
Depends on: 949333
Blocks: metrov1it5 853391
  Show dependency treegraph
 
Reported: 2013-03-26 06:56 PDT by Jim Mathies [:jimm]
Modified: 2014-07-24 11:06 PDT (History)
10 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (15.65 KB, patch)
2013-03-26 17:42 PDT, Rodrigo Silveira [:rsilveira] [:rodms]
mbrubeck: review+
mbrubeck: checkin+
Details | Diff | Splinter Review

Description Jim Mathies [:jimm] 2013-03-26 06:56:17 PDT
See bug 853391. We will not support this feature in metrofx.
Comment 1 Rodrigo Silveira [:rsilveira] [:rodms] 2013-03-26 17:42:16 PDT
Created attachment 729901 [details] [diff] [review]
Patch v1

I kept browser\metro\base\content\preferences.js because it's used by the patch for bug 845484. Once that one lands I can update this patch.
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-03-27 18:58:01 PDT
https://hg.mozilla.org/mozilla-central/rev/5c4bad14048d
Comment 4 Virgil Dicu [:virgil] [QA] 2013-04-05 07:03:25 PDT
Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130404 Firefox/23.0

No Master Password in Options. Visiting and logging in to a site which requires authentication saved the password without problems.
Comment 5 Kamil Jozwiak [:kjozwiak] 2013-04-30 20:14:35 PDT
Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Ensured that "Master Password" is not present under "Options" in the "Setting" charm
- Ensured that a "Remember Password" prompt appears at the top of the browser when logging into a website with a password
- Ensured that selecting "Remember Password" saves the passwords and can be used to re-login without issues (tried several different sites)
- Ensured that you can "Change" the password if you inserted an incorrect password previously
- Ensured that selecting "Clear" under "Options" removes all of the saved passwords
Comment 6 Kamil Jozwiak [:kjozwiak] 2013-06-14 20:43:31 PDT
Went through the following "Change" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-14-03-11-00-mozilla-central/

- Went through the test cases added in comment 5 without any issues
- Ensured that selecting "Not for this site" will not ask the user to remember the password again for that particular site
- Ensured that the "Remember Password" is not dismissed until a user makes a selection

Found Bug 883484 when going through the following "Change" but found a better "Story" to block.
Comment 7 Asa Dotzler [:asa] 2013-07-10 13:19:02 PDT
This does not have a story to attach to since it's a removal of a feature that was never captured in a Metro story.
Comment 8 Samvedana (:Samvedana) 2013-08-26 00:10:35 PDT
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment5 and 6 got expected result.
Comment 9 aasymonds 2013-08-27 13:28:48 PDT
FWIW in the current Metro build, when I forced a sync with my account which has a master account set up IN ADDITION to other security measures I have in place and all my passwords were brought in but no master password is ever needed within Metro.

I think it's a really bad idea to not allow a user to encrypt passwords at the Metro Firefox level via the existing sync system especially considering the recent press regarding Chrome's lack of a master password issue.
Comment 10 Asa Dotzler [:asa] 2013-08-27 13:51:16 PDT
(In reply to aasymonds from comment #9)
> FWIW in the current Metro build, when I forced a sync with my account which
> has a master account set up IN ADDITION to other security measures I have in
> place and all my passwords were brought in but no master password is ever
> needed within Metro.
> 
> I think it's a really bad idea to not allow a user to encrypt passwords at
> the Metro Firefox level via the existing sync system especially considering
> the recent press regarding Chrome's lack of a master password issue.

Thank you for your input, aasymonds. For future reference, advocacy comments are not appropriate for Bugzilla.  You can learn more about how we use Bugzilla here https://bugzilla.mozilla.org/page.cgi?id=etiquette.html

Note You need to log in before you can comment on or make changes to this bug.