854927 - Remove callback from new async getCharsetForURI in PlacesUtils

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Raymond Lee [:raymondlee]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/PlacesUtils.jsm#2136

Comment 1

[Raymond Lee [:raymondlee]]

Remove the callback from the new async getChaersetForURI, since we can use the promise as getCharsetForURI(...).then(callback)

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

http://mxr.mozilla.org/mozilla-central/ident?i=getCharsetForURI doesn't show any callers are using the second argument so it's safe to remove that.

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 729998 [details] [diff] [review]
v1

Review of attachment 729998 [details] [diff] [review]:
-----------------------------------------------------------------

yep, sorry for the double change here, my fault.
We never need to provide both a promise and a callback hook, since the promise can do callbacks.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Passed Try
https://tbpl.mozilla.org/?tree=Try&rev=57de1583eb0e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c291c98a1bfc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c291c98a1bfc