855021 - [Browser] tab tray doesn't open upon first launch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

## Environment :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia   ace1eb32a313da1232bbdf9cff2581a4b036356d
BuildID 20130326070204
Version 18.0
Unagi
  
## Repro :
1. make sure browser is not open at all using the task manager
2. launch browser
3. immediately after launch try opening the tab tray

## Expected :
tab tray opens

## Actual :
tab tray doesn't open; the arrow indicator points as if it was open

## Note :
1. http://www.youtube.com/watch?v=AnQTDM2rAD0&feature=youtube_gdata_player
2. master is not affected.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

work around is to change orientation and then retry as shown in video.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

affects 1.0.1

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia   c33b1f8b60edc223ba86dd22f912effee990132a
BuildID 20130327070203
Version 18.0

Comment 4

[Alex Keybl [:akeybl]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=853444#c5 for another regression window

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

This appears to be a regression; QA - we could really use the regression window.

Comment 6

[Andrew Overholt [:overholt]]

My own testing confirms bug 853444 (which has more info in general):  if I wait for a page to load entirely (no more scrolling progress bar), *then* I can open more tabs.  Once *one* tab is fully loaded, I can open other tabs.

Regression window is at https://bugzilla.mozilla.org/show_bug.cgi?id=853444#c5 as Alex noted.

David, should Ben take this when he gets back on Wednesday?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I've also see this not on first launch -- in particular, after opening a link from twitter (which opens the link in a new tab), I couldn't get the UI to close that tab and get back to twitter.


(In reply to Andrew Overholt [:overholt] from comment #6)
> David, should Ben take this when he gets back on Wednesday

Whatever caused this should get backed out well before Wednesday; the constant stream of bugs like this (breaking basic functionality) is what makes it hard for people to use builds as dogfood, which makes it less likely that we'll *find* the next level of bugs.

Comment 8

[Ben Francis [:benfrancis]]

Wow, it took me a while to figure out how this happened, but it seems that bug 849280 was uplifted but is subtly dependent* on bug 830644 which wasn't.

Bug 849280 itself was uplifted in order to fix a regression which was introduced by uplifting bug 836647 so I wouldn't recommend backing it out.

The obvious way to fix this is to uplift bug 830644, but I'm not sure where this chain of dependencies is going to end! I think these branches have existed too long, they're diverging too far away from master. Hopefully the madness will end soon.

*By way of explanation, bug 849280 removed a call to the handleWindowResize method which sets the transform on the #main-screen div to move it off the screen because it was dead code after the changes made in bug 830644.

Comment 9

[Ben Francis [:benfrancis]]

On second thoughts, that's not going to work. The commit that we need (e0d4130a06481c881cbac587bf856f3730b4e505) has a lot of other dependencies.

I think we're going to have to create a bugfix specific to the v1-train and v1.0.1 branches which will never apply to master.

Comment 10

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/8979

This is a bugfix for the v1-train and v1.0.1 branches but isn't needed on master.

The pull request is agains the v1.0.1 branch so the commit will need cherry picking for v1-train as well.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does this also fix the bookmarks UI not showing up when I click in the URL bar, or should I file a separate bug for that?

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 732979 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/8979

Good catch

Comment 13

[Dale Harvey (:daleharvey)]

> Does this also fix the bookmarks UI not showing up when I click in the URL bar, 
> or should I file a separate bug for that?

I havent been able reproduce any bug that looks like that before or after this patch so yeh file separately

Comment 14

[Ben Francis [:benfrancis]]

Thanks Dale, https://github.com/mozilla-b2g/gaia/commit/73c24b0b8fa34da37e5cbdda188595c2bd9b4c25

This will need uplifting to v1-train (original commit is df74281954ea1b3b03526bc70deba84e42c1b482)

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: bf6b8e306b1eea4b6b8ae206eca4716ce70e1262

Comment 16

[Carlos Martínez Toral [:carlosmartinez]]

Verified fixed in ikura device with build identifier 20130414230203 from V1.0.1 and gaia commit 3a7dda889.