855230 - Don't use CaptionText colour for luna-blue in fullscreen (-moz-dialog background)

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

Attachment: v.1 Simple patch to add :not([inFullscreen]) to selector

The titlebar colour isn't shown on the tabs toolbar in fullscreen mode so tab text using CaptionColor is unreadable.

STR:
1) Switch to luna blue XP theme
2) Maximize the window
3) Enter fullscreen with F11

Make sure tab text is readable.

Either one of you can review this simple patch.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 730055 [details] [diff] [review]
v.1 Simple patch to add :not([inFullscreen]) to selector

> %ifndef WINDOWS_AERO
> /* Use lighter colors of buttons and text in the titlebar on luna-blue */
> @media (-moz-windows-theme: luna-blue) {
>-  #main-window[tabsintitlebar] .tabbrowser-tab:not([selected]):not(:-moz-lwtheme) {
>+  #main-window[tabsintitlebar]:not([inFullscreen]) .tabbrowser-tab:not([selected]):not(:-moz-lwtheme) {
>     color: CaptionText;
>   }

As mentioned in bug 738491 comment 152, this shouldn't be luna-blue-specific.

>   #main-window[tabsintitlebar] .tabbrowser-arrowscrollbox > .scrollbutton-up,
>   #main-window[tabsintitlebar] .tabbrowser-arrowscrollbox > .scrollbutton-down {
>     list-style-image: url(chrome://browser/skin/tabbrowser/tab-arrow-left-inverted.png);
>   }

This needs an update as well.

Comment 2

[Matthew N. [:MattN]]

Attachment: v.2 move tab text color outside luna-blue and fix other luna-blue styles in fullscreen

(In reply to Dão Gottwald [:dao] from comment #1)
> >     color: CaptionText;
> 
> As mentioned in bug 738491 comment 152, this shouldn't be luna-blue-specific.

Ah, I didn't fully understand what was being asked there and forgot to clarify.

> This needs an update as well.

Sorry, I should have realized the other luna-blue styles needed updating.

Comment 4

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/8313c2f94b91