855301 - Add support for native theming of <input type=range> on Linux

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jonathan Watt [:jwatt]]

We need to add support for native theming of <input type=range> on Linux.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

As far as I can tell there isn't any good reason to be painting the background color for <xul:scale>, and we definitely don't want it for <html:input type=range>. Maybe we're painting the background of the widget so we can flag it as being opaque for perf, but I can't imagine that <xul:scale> is a perf issue for us.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 730838 [details] [diff] [review]
patch

Review of attachment 730838 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/forms/nsRangeFrame.cpp
@@ +189,4 @@
>    if (ShouldUseNativeStyle()) {
>      return NS_OK; // No need to reflow since we're not using these frames
>    }
> +#endif

I don't think it's worth creating a different code path here just for a tiny optimization on MacOSX.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2760f4cfce74

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2)
> I don't think it's worth creating a different code path here just for a tiny
> optimization on MacOSX.

Yeah, I was kind of thinking the same. Dropped it.

Thanks for the review!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2760f4cfce74