855420 - [B2G] [OTA]: After System OTA is downloaded if Later is selected, phone will have to restart to download/install update

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Allen Maxwell]

Attachment: After Step 4 LogCat

Description:
After device has started downloading OTA, it must be install when prompted otherwise device will have to be restarted and download OTA update again.

Repro Steps:
1) Updated to Unagi Build ID: 20130326070204
2) With update channel set to nightly, download OTA update
3) When install screen appears select Later
4) In notification screen; try to install update

Actual:
OTA download will start again but will never complete uncompressing. 

Expected:
OTA update will install

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia: ace1eb32a313da1232bbdf9cff2581a4b036356d

Notes:
Repro frequency: 100%
Q Analysts Test Team Priority: Pri 2
Restarting device will allow OTA to downloaded again and install

Comment 1

[Alex Keybl [:akeybl]]

Adding qawanted to see if v1.0.1 is affected.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Getting the same issue on v1.0.1

04-01 11:47:07.430: I/Gecko(110): *** AUS:SVC Creating Downloader
04-01 11:47:07.430: I/Gecko(110): *** AUS:SVC UpdateService:_downloadUpdate
04-01 11:47:07.430: I/Gecko(110): *** AUS:SVC readStatusFile - status: applied, path: /data/local/updates/0/update.status
04-01 11:47:07.430: I/Gecko(110): *** AUS:SVC Downloader:_selectPatch - found existing patch with state: applied
04-01 11:47:07.430: I/Gecko(110): *** AUS:SVC Downloader:_selectPatch - failed to apply complete patch!
04-01 11:47:07.450: D/memalloc(110): /dev/pmem: Allocated buffer base:0x4ae00000 size:81920 offset:1228800 fd:105
04-01 11:47:07.450: D/memalloc(463): /dev/pmem: Mapped buffer base:0x43a00000 size:1310720 offset:1228800 fd:28
04-01 11:47:07.470: I/Gecko(110): *** AUS:SVC Downloader:downloadUpdate - no patch to download
04-01 11:47:07.470: I/Gecko(110): *** AUS:SVC readStatusFile - status: null, path: /data/local/updates/0/update.status
04-01 11:47:07.480: D/memalloc(110): /dev/pmem: Freeing buffer base:0x4af2c000 size:81920 offset:1228800 fd:105
04-01 11:47:07.490: I/IdleService(110): Get idle time: time since reset 84 msec
04-01 11:47:07.490: I/Gecko(110): UpdatePrompt: Update is ready to apply, registering idle timeout of 600 seconds before prompting.
04-01 11:47:07.490: I/GeckoDump(110): XXX FIXME : Got a mozContentEvent: update-available-result

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b28463f2e718
Gaia   381103c6cdbc491591b752fe343b662307f72957
BuildID 20130330230204
Version 18.0

Comment 4

[Walter Chen[:ypwalter][:wachen]]

https://bugzilla.mozilla.org/show_bug.cgi?id=842890

Comment 5

[Marshall Culpepper [:marshall_law]]

I'm pretty sure this is a duplicate of Bug 861107, which just landed in Birch. Allen, can you restest this with my patch and see if it still occurs?

Comment 6

[Allen Maxwell]

Attachment: Log Cat of build 2013-04-17-070204

This issue still occurs on Unagi v1.1 Mozilla build 20130417070204

Build ID: 20130417070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d1b2e28b303f
Gaia: 3774a756e70ec322d363b49d29fea43c5b214cff

Comment 7

[Marshall Culpepper [:marshall_law]]

Thanks for the additional log!

After you choose "Install Later", how long are you waiting before you restart? IIRC the current logic will re-prompt you after ~10 minutes of idle time.

Comment 8

[Etienne Segonzac (:etienne)]

We probably want to display the "apply prompt" again if the user taps the notification in the utility tray _after_ having delayed the install a first time.

So we need to detect that the only update in the queue is a delayed system update and ask it to display the apply prompt again (when the notification is taped [1]).


Marshall, if we send a update-prompt-apply-result->wait and then decide on our own to send a update-prompt-apply-result->restart (before the gecko timer kicks in), will it work?

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/update_manager.js#L180-196

Comment 9

[Marshall Culpepper [:marshall_law]]

(In reply to Etienne Segonzac (:etienne) from comment #8)
> 
> Marshall, if we send a update-prompt-apply-result->wait and then decide on
> our own to send a update-prompt-apply-result->restart (before the gecko
> timer kicks in), will it work?
> 

Yeah, it should work. This is the original way I tested the restart/wait prompt, with a static notification that would re-show the prompt from Gaia.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Does this bug block certification or partner requirements for v1.1?  The OTAs work, an extra download is unfortunate but will still keep a user up to date - so is this a must-fix for v1.1 or can we just take an uplift when ready?

Comment 11

[David Scravaglieri [:scravag]]

As per comment 10. The workaround is enough for now but definitely tracking.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Does the issue still exist? I downloaded the latest v1-train Nightly for Unagi from the previous nightly, selected 'Later' and opened the system notification for an available update 40 minutes later. While the button has the label 'Download', tapping it will immediately show the install prompt (because the update is 48 MB, it is distinguishable).

Comment 13

[Gregor Wagner [:gwagner]]

Lets reopen if it still reproduces.