Extra blank box to the left of 'Done.' on mac classic skin.

RESOLVED WORKSFORME

Status

SeaMonkey
Themes
--
trivial
RESOLVED WORKSFORME
17 years ago
10 years ago

People

(Reporter: stephend@netscape.com (gone - use stephen.donner@gmail.com instead), Assigned: andreww)

Tracking

({classic})

Trunk
PowerPC
Mac System 9.x
classic

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Build ID: 2001-06-12-08, Mac Classic 

There exists an extra small box the size of the offline indicator,
which is to the left of the Done. status.  

Note: On Mac Modern, there is a blank SPACE, but not a square.  Whatever code is
causing this same bug.
downgrading to minor
Severity: normal → minor

Comment 2

17 years ago
Changing platform
Hardware: PC → Macintosh

Updated

17 years ago
Keywords: classic

Updated

17 years ago
Blocks: 91504

Comment 3

17 years ago
Created attachment 48953 [details] [diff] [review]
begone

Comment 4

17 years ago
r/sr=blake
Comment on attachment 48953 [details] [diff] [review]
begone

this rule is now empty and useless, just turn it into a comment; that removes the rule and helps resurrecting it just in case.

This bug is mac-classic specific and should be tested on a Mac.

r=glazman **providing the fact that it is visually tested on a Mac**.
Attachment #48953 - Flags: review+

Comment 6

17 years ago
r=ksosezoff to bed now.

Comment 7

17 years ago
fix checked into trunk, requesting branch approval this is an eyesore and 
verylow risk
Keywords: mozilla0.9.4

Comment 8

17 years ago
Comment on attachment 48953 [details] [diff] [review]
begone

low risk medium reward. a=asa for checkin to the 0.9.4 branch
Attachment #48953 - Flags: approval+

Comment 9

17 years ago
thanks
Assignee: sspitzer → timeless
Component: Subscribe → Themes
Product: MailNews → Browser
Target Milestone: --- → mozilla0.9.4

Comment 10

17 years ago
fix checked into trunk and branch
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
/me wonders what is the point asking for reviews if you don't follow
them and ask for other reviews when the existing one are not matching
your desire.

Why did you keep the empty ruleset in (that was in my review) ?

(Assignee)

Comment 12

17 years ago
yes the rule should have been removed as well. This is a leftover from 
blake making a fix to windows classic skin and not (at the time) able to 
access mac classic.  The class selector should have been removed as 
well.

Comment 13

17 years ago
I apologize for reviewing this hastily, I thought the entire rule was removed.

Comment 14

17 years ago
Created attachment 49066 [details] [diff] [review]
trunk only; move whitespace (kill tabs, increase consistency) and whack the empty rule

Comment 15

17 years ago
Created attachment 49067 [details] [diff] [review]
same patch, -u0w for reviewing (to show this doesn't do anything significant)

Comment 16

17 years ago
what's the point of complaining if you aren't going to listen to the response?

the patch itself needed to go in before 094 finalized, it did.  i've attached a 
cleanup patch which is designed for trunk only (since it benefits the branch so 
insignificantly it would only add risk, and therefor fail any sane risk/benefit 
analysis).

Comment 17

17 years ago
Changing the coding style in that file makes it inconsistent with the coding
style in all other files in that theme.

If you intend to make it consistent, please fix the unusual cases and not the
entire file.

that patch needs-work.

Comment 18

17 years ago
Ok, turns out some parts of mac-classic is written in one code style and some in
another.

Timeless, I suggest you just leave it alone (or create a new bug if you really
intend to "fix" it) - just make glazou's requested change (removing the unused
rule).
Re-opening, until the final patch has been through the reviewal and checkin process.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 20

17 years ago
moved per 0.9.5 per pdt mtg.
Target Milestone: mozilla0.9.4 → mozilla0.9.5

Comment 21

16 years ago
.
Assignee: timeless → andreww
Severity: minor → trivial
Status: REOPENED → NEW
Target Milestone: mozilla0.9.5 → ---
(Assignee)

Comment 22

16 years ago
the stuff that this patch would have fixed was already done in bug 97574.
Marking worksforme since it's already in .
Status: NEW → RESOLVED
Last Resolved: 17 years ago16 years ago
Resolution: --- → WORKSFORME
themes --> QA to pmac
QA Contact: stephend → pmac
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.