Closed Bug 855465 Opened 7 years ago Closed 7 years ago

Add emacs python mode comments to moz.build files

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: qdot, Assigned: qdot)

References

Details

Attachments

(1 file, 2 obsolete files)

moz.build files come with vi modesets. [insert religious war comment here]. We should add emacs also. I realize there's more than 2 python modes in emacs history, so I'm going to assume modern and go with fgallina's python-mode.

Just need to add the following line to the top of all the moz.build files (assuming we're doing pep8 compatible python?):

# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-
Whoops, just wanted moz.build, not *.build.
Attachment #730358 - Attachment is obsolete: true
Attachment #730360 - Flags: review?(gps)
Comment on attachment 730358 [details] [diff] [review]
Patch (v1) - Add emacs python-mode comments to moz.build files

That makes me sad that the header now has to be 5 lines...
It does feel a little weird that the header will probably be longer than a lot of the files, but since it's a whitespace sensitive language, it'd be nice to get this locked down before inevitable untested-one-line-change burnage.
Comment on attachment 730360 [details] [diff] [review]
Patch (v2) - Add emacs python-mode comments to moz.build files

Review of attachment 730360 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe one day we'll rename all these files to .py so we won't have this problem.

Until then, rs=gps.
Attachment #730360 - Flags: review?(gps) → review+
Needed to update test_reader line numbers
Attachment #730360 - Attachment is obsolete: true
I granted IRC r+ post check-in.
https://hg.mozilla.org/mozilla-central/rev/5f4f68f00419
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
I see you ignored the

# THIS FILE IS AUTOGENERATED BY importTestsuite.py - DO NOT EDIT

comments.
Blocks: 1286877
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/39dc6e2c2140
Add emacs python mode comments to moz.build files; r=gps
https://hg.mozilla.org/comm-central/rev/2c4e3be38014
Backout for changeset 39dc6e2c2140 due to bustage on a CLOSED TREE; r=qdot
https://hg.mozilla.org/comm-central/rev/51d07d8d4ebf
Add emacs python mode comments to moz.build files; r=gps
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.