855502 - we need a proper design for the new checkboxes

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Paul Rouget [:paul]]

The crosses are not that great.

Comment 1

[u443210]

Attachment: Proposed checkbox

Maybe we can use the checkbox present in the timeline of events...

Comment 2

[Girish Sharma [:Optimizer]]

(In reply to scheco from comment #1)
> Created attachment 730743 [details]
> Proposed checkbox
> 
> Maybe we can use the checkbox present in the timeline of events...

In dark theme, maybe yes. They are taken from the initial dark theme mockups of shorlander after all.

Comment 3

[u443210]

Attachment: Rudimentary mockup.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Switch to using images ... no more crosses.

The crosses looked bad and were not visible on Windows 7 (bug 859686) so I have switched to using images. The dark themed one is from Shorlander's mockup and I made the light one.

The light one should probably be redesigned by shorlander but please disregard that for the purposes of the review.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Screenshot of the patched version

Already tested across OSes.

Comment 6

[Brandon Benvie [:benvie]]

Comment on attachment 736316 [details] [diff] [review]
Switch to using images ... no more crosses.

Review of attachment 736316 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Because this is an important issue on Windows 7 we may as well land it as it is.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/630fa3185e7e

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/630fa3185e7e

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 736316 [details] [diff] [review]
Switch to using images ... no more crosses.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 859686
User impact if declined: Checkboxes will not be visible on Windows 7
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): No risk, purely cosmetic
String or IDL/UUID changes made by this patch: None

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 736316 [details] [diff] [review]
Switch to using images ... no more crosses.

Approving for FF22, and pinging shorlander to make sure there aren't any concerns with this shipping in FF22 due to bug 859686.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 736316 [details] [diff] [review]
Switch to using images ... no more crosses.

adding the plus that got left off of akeybl's pass-through

Comment 13

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d7ba42f5cef4

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on Firefox 22 Beta 6 (Build ID: 20130617145905) on Windows 7, Windows 8, Ubuntu and Mac OS X.

User Agents:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20100101 Firefox/22.0