859686 - Checkbox in Style Rule view are not drawn properly on Windows 7

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/releases/mozilla-aurora/rev/05e799145245
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130408 Firefox/22.0 ID:20130408004015

Steps to Reproduce:
1. Make sure desktop style Windows7 Classic
2. Start Firefox
3. Launch Dom Inspector
4. Click Checkbox in Style Rule view

Actual result:
Checkbox is always white rectangle, no check mark appears.

Expected Results:
check mark should be toggled (appear/disappear).

Regression window:
Good:
http://hg.mozilla.org/integration/fx-team/rev/f09e10680ee4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130327 Firefox/22.0 ID:20130327083604
Bad:
http://hg.mozilla.org/integration/fx-team/rev/36332ce24dd1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130327 Firefox/22.0 ID:20130327152206
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f09e10680ee4&tochange=36332ce24dd1

Regressed by: Bug 836233

Comment 1

[Girish Sharma [:Optimizer]]

Happens on Windows 7 Aero mode also.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Does anybody have a screenshot?

Comment 3

[Alice0775 White]

Attachment: screenshot

Comment 4

[Girish Sharma [:Optimizer]]

Attachment: screenshot

The checkbox is not hovered. It is missing the cross. Using DOMi, I don't even see a background image property to the icon.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yes, the reason I asked is because I wanted to check if this was the old or the new theme. I think that the cross in the checkbox is confusing anyhow ... a cross next to something normally erases, rather than disables it.

I suspect that an image, something like Firebug uses, is better.

Comment 6

[Victor Porof [:vporof][:vp]]

Why use themed checkboxes?

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Because native ones look terrible with the dark theme (styling options are very limited).

Comment 8

[Alex Keybl [:akeybl]]

Michael - can you take a look in Paul's absence?

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yes, I am fixing this as part of bug 855502.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This was fixed as part of bug 855502.

Comment 11

[Maria Grazia Alastra [:mga]]

Verified as fixed on Windows 7, 64 bits, with Aurora 23.0 and latest Nightly 24.0:

- User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130519 Firefox/23.0, Build ID: 20130519004019

- User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:24.0) Gecko/20130519 Firefox/24.0, Build ID: 20130519031035

Comment 13

[Loic]

Is it going to be fixed in Firefox 22 too?

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Loic from comment #13)
> Is it going to be fixed in Firefox 22 too?

Yes, we should also land this in 22.

Comment 15

[Dave Camp (:dcamp)]

This was fixed in bug 855502

Comment 16

[Maria Grazia Alastra [:mga]]

Verified as fixed also on Windows 7, 64 bits, with Firefox 22 beta 4, User agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0, Build ID: 20130605070403