Closed Bug 855568 Opened 7 years ago Closed 7 years ago
Element Audio Source Node
MediaElementAudioSourceNode is defined here: <https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#MediaElementAudioSourceNode>.
Matthew, did you want to work on this? :-) FWIW I think we should first implement MediaStreamAudioSourceNode (bug 856361) and then use mozCaptureStream to implement this node type.
Depends on: 856361
I don't think I've got time right now sorry, I just wanted to file it for the bug 855570 deps.
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
Added a test, it doesn't pass and it crashes. But Bobby wanted to see it.
Attachment #761214 - Attachment is obsolete: true
7 years ago
Assignee: ehsan → roc
The test originally attached to this patch won't work since playback of the media element may introduce silence (especially at the start) while the media element decoding pipeline spins up.
Basically you already had, which I've reviewed/tweaked a bit, plus a new test which is just test_mediaStreamAudioSourceNodeResampling.html but using MediaElementAudioSourceNode instead of MediaStreamAudioSourceNode. Nice and simple implementation :-).
Comment on attachment 780774 [details] [diff] [review] patch Review of attachment 780774 [details] [diff] [review]: ----------------------------------------------------------------- It would also be really great if you could add a test similar to test_mediaStreamAudioSourceNode.html. r=me with that.
Attachment #780774 - Flags: review?(ehsan) → review+
You mean where the track sample rate is equal to the context sample rate? I don't think that's really necessary given this is a very thin wrapper around MediaStreamAudioSourceNode.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #10) > You mean where the track sample rate is equal to the context sample rate? I Yes. > don't think that's really necessary given this is a very thin wrapper around > MediaStreamAudioSourceNode. Hmm that's a fair point given our knowledge about the implementation, but I'd still like us to test the API surface there. If you want, I'm fine with us doing this in another bug though.
Push backed out for mochitest-1 failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f7496fddb076 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/6946b8d86502 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/31453209a88a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/c43900741e9a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/3f150133a4de remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd005b9e9d7 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/6e72a4e894e1 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f30f29ffa1f remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/fab0e9b04d8d remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4382f83efcaf remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/47f46080685f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment on attachment 780774 [details] [diff] [review] patch This is needed for Web Audio in Firefox 25.
checkin-needed for Aurora, a=webaudio.
Backed out for mochitest failures. https://hg.mozilla.org/releases/mozilla-aurora/rev/918a847c0018 https://tbpl.mozilla.org/php/getParsedLog.php?id=26380446&tree=Mozilla-Aurora
Assuming this doesn't need QA.
Doc is up-to-date: https://developer.mozilla.org/en-US/docs/Web/API/MediaElementAudioSourceNode
You need to log in before you can comment on or make changes to this bug.