Closed Bug 855568 Opened 7 years ago Closed 7 years ago

Implement MediaElementAudioSourceNode

Categories

(Core :: Web Audio, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: kinetik, Assigned: roc)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

Blocks: 855570
Matthew, did you want to work on this?  :-)

FWIW I think we should first implement MediaStreamAudioSourceNode (bug 856361) and then use mozCaptureStream to implement this node type.
Depends on: 856361
I don't think I've got time right now sorry, I just wanted to file it for the bug 855570 deps.
Assignee: nobody → ehsan
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
Attached patch WIP (obsolete) — Splinter Review
Attached patch WIP (obsolete) — Splinter Review
Added a test, it doesn't pass and it crashes.  But Bobby wanted to see it.
Attachment #761214 - Attachment is obsolete: true
Assignee: ehsan → roc
The test originally attached to this patch won't work since playback of the media element may introduce silence (especially at the start) while the media element decoding pipeline spins up.
Attached patch patchSplinter Review
Basically you already had, which I've reviewed/tweaked a bit, plus a new test which is just test_mediaStreamAudioSourceNodeResampling.html but using MediaElementAudioSourceNode instead of MediaStreamAudioSourceNode. Nice and simple implementation :-).
Attachment #761761 - Attachment is obsolete: true
Attachment #780774 - Flags: review?(ehsan)
Comment on attachment 780774 [details] [diff] [review]
patch

Review of attachment 780774 [details] [diff] [review]:
-----------------------------------------------------------------

It would also be really great if you could add a test similar to test_mediaStreamAudioSourceNode.html.  r=me with that.
Attachment #780774 - Flags: review?(ehsan) → review+
You mean where the track sample rate is equal to the context sample rate? I don't think that's really necessary given this is a very thin wrapper around MediaStreamAudioSourceNode.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #10)
> You mean where the track sample rate is equal to the context sample rate? I

Yes.

> don't think that's really necessary given this is a very thin wrapper around
> MediaStreamAudioSourceNode.

Hmm that's a fair point given our knowledge about the implementation, but I'd still like us to test the API surface there.  If you want, I'm fine with us doing this in another bug though.
https://hg.mozilla.org/mozilla-central/rev/27f384522675
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment on attachment 780774 [details] [diff] [review]
patch

This is needed for Web Audio in Firefox 25.
Attachment #780774 - Flags: approval-mozilla-aurora?
checkin-needed for Aurora, a=webaudio.
Keywords: checkin-needed
Attachment #780774 - Flags: approval-mozilla-aurora?
Assuming this doesn't need QA.
Whiteboard: [qa-]
Depends on: 934100
Depends on: 937718
Depends on: 937962
Depends on: 944924
You need to log in before you can comment on or make changes to this bug.