855581 - Defect - New tab created if you receive "Leave Page" error and only a single tab is present

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

When you only have a single tab opened and you receive the error message indicating that you are about to leave the website and the data entered will not be saved, a new tab will be created despite selecting "Stay on Page"

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to stackoverflow.com
3) Select a random question
4) Insert something random in the "Reply" field
5) Select the "X" on the tabs app bar (make sure that's your only tab currently opened). You will notice a new tab being created
6) Select "Stay on Page" (Notice the new Tab)

Current Behavior:

- When you only have a single tab opened and you receive the error message indicating your data will not be saved, a new tab is automatically created

Expected Behavior:

- A new tab should only be created if the user selects "Leave Page" and there is no other tabs currently opened

Comment 1

[Kamil Jozwiak [:kjozwiak]]

it5 consideration?

Comment 2

[Marco Mucci [:MarcoM]]

Moving to Iteration #5 for consideration as a Defect Story.

Comment 3

[Brian R. Bondy [:bbondy]]

This is probably related to the code for opening a new tab when the last tab is closed. We should make sure the tab is actually closing before executing that logic.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1

This patch slightly rearranges some "close tab" logic in browser.js and browser-ui.js so that we only open a new tab if the last tab is actually closing.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 738280 [details] [diff] [review]
Patch v1

Review of attachment 738280 [details] [diff] [review]:
-----------------------------------------------------------------

Yay for less setTimeouts!

Thanks for working on this. :)

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49b7327cd49f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/49b7327cd49f

Comment 8

[Marco Mucci [:MarcoM]]

For Virgil to test and verify.

Comment 9

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130421 Firefox/23.0

Scenario in comment 0 is no longer reproducible.

Filed bug 864247 for case when back button is selected with the dialog open.

In addition:
-checked that both options of the dialog performed the desired action with one tab/multiple tabs open
-checked back/new tab buttons functionality with the prompt open

Comment 10

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Verified for it8

Comment 11

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

By the way, this test could easily be automated.  Perhaps we should automate this test to reduce the load on our QA team?