855587 - Defect - Predefined bookmarks should be to final URL and not to a page that will redirect

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Bookmarks, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

Predefined bookmarks should be to final URL(s) and not to a page that will redirect. Because of this, the predefined bookmarks that come with Firefox Metro have the "Bookmark Star" disabled despite appearing under the "Bookmarks" column. This could confusing to new users.

Steps to reproduce the issue:

1)Open Firefox Metro
2)Select either "About Us", "Getting Started" or "Get Involved" from the "Bookmarks" column
3)Press Windows + Z to receive the app bar and notice that the "Bookmark Star" is disabled

Current Behavior:

- Predefined bookmarks have the "Star" disabled in the app bar

Expected Behavior:

- Predefined bookmarks should have the "Star" enabled as they are technically bookmarks

Comment 1

[Kamil Jozwiak [:kjozwiak]]

it5 consideration?

Comment 2

[Marco Mucci [:MarcoM]]

Moving to Iteration #5 for consideration as a Defect Story.

Comment 3

[Marco Mucci [:MarcoM]]

Being placed into Story Backlog based on Asa's review.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Is this caused by bug 845983?

The fix is probably to link directly to the page that will be redirected to.

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: patch v1

This patch seems to fix the issue.  Note: To see the bookmarks star appear correctly for pre-defined bookmarks, you'll have to clear your MetroFirefox profile.

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 734768 [details] [diff] [review]
patch v1

looks good to me!

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Pushed to inbound:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/cc4abdf71cb8

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc4abdf71cb8

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #5 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-13-03-09-27-mozilla-central/

Failed Cases:

- The "Get Involved" website under the "Bookmarks" doesn't have the "Star" enabled when selecting it under "Bookmarks". It should be consistent with the websites mentioned below in the "Passed Cases"

Passed Cases:

- Installed Firefox and ensured that the websites are correctly appearing under "Bookmarks"
- When selecting the "About Us" website from the Bookmarks, the "Star" is enabled
- When selecting the "Getting Started" website from the Bookmarks, the "Star" is enabled

Comment 10

[Marco Mucci [:MarcoM]]

Moving to Iteration #6 for development.

Comment 11

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Part 2 Patch v1

Looks like I should have tried all 3 links :/

This patch should fix the issue but I just pulled from mc so I have to wait a little longer for my build to complete.

When it's done I'll r?someone and land this.

Comment 12

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 738740 [details] [diff] [review]
Part 2 Patch v1

Built and tested

Comment 13

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f762ed17c6a6

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f762ed17c6a6

Comment 15

[Marco Mucci [:MarcoM]]

For Virgil to test and verify.

Comment 16

[Virgil Dicu [:virgil] [QA]]

Verified with Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130421 Firefox/23.0

All three default bookmarks: 
-have the star enabled in the app bar. (clean profile)
-lead directly to the desired page - no redirects

Also bookmarked a regular site -> star displayed in the app bar, site available in awesome page.

Comment 17

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Ensured that the three default websites are available when Firefox Metro is installed
- Checked all three default bookmarks and ensured that the bookmark "star" was enabled (tried several times by re-installing Firefox Metro)
- Removed the default Bookmarks by tapping on the "Star" and ensuring they are removed from "Bookmarks"
- Ensured that one the default websites have been removed from Bookmarks, the "Star" is disabled under the "App Bar"
- Bookmarked several websites and ensured that the "Star" is enabled and appeared under "Bookmarks" in the awesome screen
- Ensured that removing the "Star" from the Bookmarked websites removes them from the awesome screen

Comment 18

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Could not verify for it8; filed bug 881971

Comment 19

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Predefined bookmarks have the "Star" enabled.