855607 - B2G MMS: Notify user while retrieving expiried notification indication.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

When download option set to manual, the end user might retrieve an expiried notification. We should deal with this situation.

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

In OMA-TS-MMS_ENC-V1_3-20110913-A, tbale 3 Header fields of M-Notification.ind PDU in chapter 6.2 mentions that X-Mms-Expiry is mandatory field.It is the length of time the message will be available. The field has only one format, relative.

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.0

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.1

Fix typo.

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.2

Another typo.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 732646 [details] [diff] [review]
Patch v1.2

Review of attachment 732646 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mms/src/ril/MmsService.js
@@ +1050,5 @@
>      // For X-Mms-Report-Allowed
>      let wish = notification.headers["x-mms-delivery-report"];
> +    // The x-mms-expiry is mandatory and relative time in notification indication.
> +    let expiryTime = notification.headers["x-mms-expiry"] * 1000;
> +    notification.expiryDate = Date.now() + expiryTime;

Please don't actively assign any header values as direct attributes of the message object.

@@ +1353,5 @@
> +            aRequest.notifyDeleteMessageFailed(aRv);
> +          }
> +        };
> +        gMobileMessageDatabaseService
> +          .deleteMessageRecordById(aMessageRecord.id, notifyCallback);

Please don't actively delete a message. That's user's decision. Return an error instead.

::: dom/mobilemessage/interfaces/nsIRilMobileMessageDatabaseService.idl
@@ +88,5 @@
> +   * |aCallback| nsIRilMobileMessageDatabaseCallback: a callback for notifying
> +   *   the deletion result.
> +   */
> +  void deleteMessageRecordById(in long aMessageId,
> +                               in nsIRilMobileMessageDatabaseCallback aCallback);

You don't need this.

::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
@@ +1385,5 @@
>      });
>    },
>  
> +  deleteMessageRecordById: function deleteMessageRecordById(aMessageId, aCallback) {
> +    if (DEBUG) debug("Deleting message with ID " + aMessageId);

ditto.

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.3

Modified accroding to comment 6.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 734495 [details] [diff] [review]
Patch v1.3

Review of attachment 734495 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mms/src/ril/MmsService.js
@@ +1338,5 @@
>          debug("Can't find mms content url in database.");
>          aRequest.notifyGetMessageFailed(Ci.nsIMobileMessageCallback.INTERNAL_ERROR);
>          return;
>        }
> +      // The x-mms-expiry is mandatory and relative time in notification indication.

nit: new line. Please cite MMS-ENC 6.2 "Multimedia Message Notification" directly:

  The field has only one format, relative. The recipient client calculates this
  length of time relative to the time it receives the notification.

Comment 9

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.4

Add new line and modify the comment.

Comment 10

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea61e47d09ca

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ea61e47d09ca

Comment 12

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

See chapter 6.2 in OMA-TS-MMS-CTR-V1_3-20110511-C.

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

Uplift WIP: https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/838467/b2g18 , verifying.

Comment 14

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/6aa156cf431c