855610 - B2G MMS: Scan pending sending/receiving transaction and set the status to fail when b2g bootup

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Somtimes we might be in bad data call environment and could not be able to retrieve or send MM. But when we come back to good data call environment, we should re-queque those pending transactions.

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

After discuss with Vicamo, let's start from scanning pending send and retrieve transaction in boot-up first.

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

After talk with Casey in Madrid, he don't want this feature. So reset assignee to default.

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

After messaging AP support MMS, looks like we need this bug fix some UI bad behaviour.
For example, if we reboot or remove the battery when we are receiving/sending MMS, we will see the spin icon forever on those messages. We need to refresh the message record when b2g start. Nominate for leo+.

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.0

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.1

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.2

Comment 8

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.3

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 757328 [details] [diff] [review]
Patch v1.3

Review of attachment 757328 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for me, just need a few adjustments to SMS messages as well. :)

::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
@@ +298,5 @@
> +          return;
> +        let messageRecord = messageCursor.value;
> +        if (messageRecord.type == "sms") {
> +          messageCursor.continue();
> +          return;

We can also have unsent SMS messages.

@@ +324,5 @@
> +        if (!messageCursor)
> +          return;
> +        let messageRecord = messageCursor.value;
> +        if (messageRecord.type == "sms") {
> +          messageCursor.continue();

We have no "not-downloaded" SMS messages, just place a comment here will do.

Comment 10

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.4

Comment 11

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.5

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 758428 [details] [diff] [review]
Patch v1.5

Review of attachment 758428 [details] [diff] [review]:
-----------------------------------------------------------------

I have a little bit concern about the new "error" value for "not-downloaded" messages.  Is it a request from UX or supported by any user stories?

::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
@@ +302,5 @@
> +      cursorRequestSending.onsuccess = function(event) {
> +        let messageCursor = event.target.result;
> +        if (!messageCursor)
> +          return;
> +        let messageRecord = messageCursor.value;

nit: I think we embrace one-liner with only one exception -- |if (DEBUG) debug("short messages");|.  Besides, please have an empty line after a return statement.  That make it more clear that following code is for another purpose.

@@ +329,5 @@
> +      cursorRequestNotDownloaded.onsuccess = function(event) {
> +        let messageCursor = event.target.result;
> +        if (!messageCursor)
> +          return;
> +        let messageRecord = messageCursor.value;

ditto

Comment 13

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #12)
> Comment on attachment 758428 [details] [diff] [review]
> Patch v1.5
> 
> Review of attachment 758428 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I have a little bit concern about the new "error" value for "not-downloaded"
> messages.  Is it a request from UX or supported by any user stories?

I think this just a bug. It is not a request UX or user story. It will spin forever without the 'error' value when we reboot during retrieving MMS.

Comment 14

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.6

Comment 15

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/d377d9d71261

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d377d9d71261

Comment 17

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5d7b49397ff4

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/5d7b49397ff4