Closed Bug 855610 Opened 8 years ago Closed 7 years ago

B2G MMS: Scan pending sending/receiving transaction and set the status to fail when b2g bootup

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: ctai, Assigned: ctai)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file, 6 obsolete files)

No description provided.
Somtimes we might be in bad data call environment and could not be able to retrieve or send MM. But when we come back to good data call environment, we should re-queque those pending transactions.
Assignee: nobody → ctai
Summary: B2G MMS: Scan pending transaction when new MMS transaction acquired. → B2G MMS: Scan pending transaction when new MMS transaction acquired or a change in network connectivity has occurred.
After discuss with Vicamo, let's start from scanning pending send and retrieve transaction in boot-up first.
Summary: B2G MMS: Scan pending transaction when new MMS transaction acquired or a change in network connectivity has occurred. → B2G MMS: Scan pending transaction when bootup
After talk with Casey in Madrid, he don't want this feature. So reset assignee to default.
Assignee: ctai → nobody
Summary: B2G MMS: Scan pending transaction when bootup → B2G MMS: Scan pending sending/receiving transaction and set the status to fail when bootup
Summary: B2G MMS: Scan pending sending/receiving transaction and set the status to fail when bootup → B2G MMS: Scan pending sending/receiving transaction and set the status to fail when b2g bootup
After messaging AP support MMS, looks like we need this bug fix some UI bad behaviour.
For example, if we reboot or remove the battery when we are receiving/sending MMS, we will see the spin icon forever on those messages. We need to refresh the message record when b2g start. Nominate for leo+.
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
Target Milestone: --- → 1.1 QE3
Attached patch Patch v1.0 (obsolete) — Splinter Review
Assignee: nobody → ctai
Attached patch Patch v1.1 (obsolete) — Splinter Review
Attachment #757323 - Attachment is obsolete: true
Attached patch Patch v1.2 (obsolete) — Splinter Review
Attachment #757325 - Attachment is obsolete: true
Attached patch Patch v1.3 (obsolete) — Splinter Review
Attachment #757327 - Attachment is obsolete: true
Attachment #757328 - Flags: feedback?(vyang)
Comment on attachment 757328 [details] [diff] [review]
Patch v1.3

Review of attachment 757328 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for me, just need a few adjustments to SMS messages as well. :)

::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
@@ +298,5 @@
> +          return;
> +        let messageRecord = messageCursor.value;
> +        if (messageRecord.type == "sms") {
> +          messageCursor.continue();
> +          return;

We can also have unsent SMS messages.

@@ +324,5 @@
> +        if (!messageCursor)
> +          return;
> +        let messageRecord = messageCursor.value;
> +        if (messageRecord.type == "sms") {
> +          messageCursor.continue();

We have no "not-downloaded" SMS messages, just place a comment here will do.
Attachment #757328 - Flags: feedback?(vyang) → feedback+
Attached patch Patch v1.4 (obsolete) — Splinter Review
Attachment #757328 - Attachment is obsolete: true
Attached patch Patch v1.5 (obsolete) — Splinter Review
Attachment #758423 - Attachment is obsolete: true
Attachment #758428 - Flags: review?(vyang)
Comment on attachment 758428 [details] [diff] [review]
Patch v1.5

Review of attachment 758428 [details] [diff] [review]:
-----------------------------------------------------------------

I have a little bit concern about the new "error" value for "not-downloaded" messages.  Is it a request from UX or supported by any user stories?

::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
@@ +302,5 @@
> +      cursorRequestSending.onsuccess = function(event) {
> +        let messageCursor = event.target.result;
> +        if (!messageCursor)
> +          return;
> +        let messageRecord = messageCursor.value;

nit: I think we embrace one-liner with only one exception -- |if (DEBUG) debug("short messages");|.  Besides, please have an empty line after a return statement.  That make it more clear that following code is for another purpose.

@@ +329,5 @@
> +      cursorRequestNotDownloaded.onsuccess = function(event) {
> +        let messageCursor = event.target.result;
> +        if (!messageCursor)
> +          return;
> +        let messageRecord = messageCursor.value;

ditto
Attachment #758428 - Flags: review?(vyang) → review+
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #12)
> Comment on attachment 758428 [details] [diff] [review]
> Patch v1.5
> 
> Review of attachment 758428 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I have a little bit concern about the new "error" value for "not-downloaded"
> messages.  Is it a request from UX or supported by any user stories?

I think this just a bug. It is not a request UX or user story. It will spin forever without the 'error' value when we reboot during retrieving MMS.
Attached patch Patch v1.6Splinter Review
Attachment #758428 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d377d9d71261
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.